[Darkside] Quality assurance P7 #3530
Conversation
|
Storybook demo / Chromaticeffaa1857 | 91 components | 135 stories |
| @@ -173,10 +170,7 @@ | |||
| } | |||
|
|
|||
| &:active { | |||
| --__axc-button-border-color: transparent; | |||
|
|
|||
| color: var(--ax-text-contrast); | |||
There was a problem hiding this comment.
it seems like so many changes, I'm guessing they are fine? (i don't seem to find any differences so far tabbing between this chromatic & a local one from main).
Here it seems active state is weaker on already weaker surfaces, and probably the intent right? 💭 (it makes sense to me to not have to jump to super high contrast for the active state if the current is very low contrast)
There was a problem hiding this comment.
These changes are only affecting :active-state, so that we no longer "flip" the color, but rather keep it on moderate for active-state
There was a problem hiding this comment.
was almost all of this unused / not needed? 🙈
There was a problem hiding this comment.
Think the buttons grew a little bit in height? Also really like the blue hover state > gray for the action variant 🎉 .
There was a problem hiding this comment.
Yes since we just use our own "Button" now, we can remove most of this ⚰️
There was a problem hiding this comment.
Buttons are now 48px, 32px and 24px. So atleast matches what they should have been now 🤞
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")