Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for placeholders in translations #3387

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Add test for placeholders in translations #3387

merged 5 commits into from
Nov 22, 2024

Conversation

HalvorHaugan
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3067857

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@HalvorHaugan HalvorHaugan marked this pull request as draft November 20, 2024 13:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

Storybook demo

38a7d188d | 91 komponenter | 135 stories

@HalvorHaugan HalvorHaugan marked this pull request as ready for review November 20, 2024 14:13
KenAJoh
KenAJoh reviewed Nov 20, 2024
View reviewed changes
@navikt/core/react/src/util/i18n/locales.test.tsx Outdated
Comment on lines 25 to 26
baseTrans: Translations | NestedValue, // Translations to check against
trans: Translations | NestedValue, // Translations to check
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't feel the shortening adds anything here

Suggested change
baseTrans: Translations | NestedValue, // Translations to check against
trans: Translations | NestedValue, // Translations to check
baseTranslation: Translations | NestedValue, // Translations to check against
translations: Translations | NestedValue, // Translations to check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for "baseTrans" was that I thought it would sometimes be an object and sometimes a string, but I just realized that it won't 😄

@navikt/core/react/src/util/i18n/locales.test.tsx Outdated
@@ -19,8 +21,34 @@ function checkValues(obj: Translations | Record<string, string>) {
});
}

function checkPlaceholders(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function checkPlaceholders(
function checkTranslationPlaceholders(

@HalvorHaugan HalvorHaugan merged commit 293fade into main Nov 22, 2024
4 checks passed
@HalvorHaugan HalvorHaugan deleted the locales-test-placeholders branch November 22, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenAJoh KenAJoh KenAJoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HalvorHaugan @KenAJoh