Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Darkside] Popover CSS update #3369

Merged
merged 7 commits into from
Nov 19, 2024
Merged

[Darkside] Popover CSS update #3369

merged 7 commits into from
Nov 19, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Nov 14, 2024

No description provided.

@KenAJoh KenAJoh requested review from a team as code owners November 14, 2024 12:06
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 054ebf5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KenAJoh KenAJoh self-assigned this Nov 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

Storybook demo

9165b088b | 91 komponenter | 135 stories

@KenAJoh KenAJoh enabled auto-merge (squash) November 19, 2024 14:13
HalvorHaugan
HalvorHaugan reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@HalvorHaugan HalvorHaugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some comments I forgot to submit

@navikt/core/react/src/popover/Popover.tsx Outdated Show resolved Hide resolved
@navikt/core/react/src/popover/Popover.tsx Outdated Show resolved Hide resolved
KenAJoh and others added 2 commits November 19, 2024 15:20
@KenAJoh @HalvorHaugan
Update @navikt/core/react/src/popover/Popover.tsx
270bc70 
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
@KenAJoh @HalvorHaugan
Update @navikt/core/react/src/popover/Popover.tsx
054ebf5 
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
@KenAJoh KenAJoh merged commit 3ac02e3 into main Nov 19, 2024
4 checks passed
@KenAJoh KenAJoh deleted the darkside-popover-css branch November 19, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalvorHaugan HalvorHaugan HalvorHaugan approved these changes

Assignees

@KenAJoh KenAJoh

Labels
Ready for review 🧙
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KenAJoh @HalvorHaugan