Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Darkside] datemonthpicker #3357

Merged
merged 38 commits into from
Dec 3, 2024
Merged

[Darkside] datemonthpicker #3357

merged 38 commits into from
Dec 3, 2024

Conversation

JulianNymark
Copy link
Contributor

Description

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

@JulianNymark JulianNymark requested review from a team as code owners November 12, 2024 14:03
Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: 26916e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@HalvorHaugan HalvorHaugan self-requested a review November 12, 2024 14:05
Copy link
Contributor

github-actions bot commented Nov 12, 2024

Storybook demo

021a0e36a | 91 komponenter | 135 stories

@HalvorHaugan HalvorHaugan removed their request for review November 12, 2024 14:08
@JulianNymark JulianNymark changed the title 🚧 wip 🚧 [Darkside] datemonthpicker Nov 12, 2024
KenAJoh and others added 10 commits November 19, 2024 09:27
* First run for errorsummary css update

* Added nesting
* ✨ Updated Dropzone with darkmode

* ♻️ Added nesting for root

* ♻️ ac -> acx prefix for interla tokens

* ♻️ Removed reduntant token

* ♻️ More nesting

* 💄 Align overlay on drag better

* ⚰️ Removed test-code

* 💄 Update hover-border for dropzone

* 🐛 Removed border-color update on hover in disabled state

* ♻️ Use bg input on area, use border default
* ✨ Darkmode-support for existing link-component

* :refactor: Adjusted line offsets and thickness
* 💄 Initial css-update expansioncard

* 📝 Added sub-headers

* 💫 Button animation

* ✨ Added data attrb for open-state

* 💫 Updated content animation

* ♻️ Added nesting

* ♻️ Better nesting of rules

* ♻️ Use outline for hover border

* ♻️ Use border as default outline

* 🔥 Remove redundant border css

* 🔥 Removed divider transition, unused state attributes in react
* :refactor: Use updated CSS for darkside

* 💄 Replace accent bg with info bg
* [aksel.nav.no] Update examples of Page

* comment

* comment + rename + style->class

* fix

* 📝 Use NAV-dekorator for Page-examples

* 🚚 Moved content to separate __parts location

* :refactor: Updated examples

* Update aksel.nav.no/website/components/website-modules/examples/__parts/PageDemoContent.tsx

Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>

* 🐛 Use correct import syntax for parts

* 📝 Add description to page-block default story

* 💄 Removed spacing from all typo-headings in demo

* 🐛 Removed react import from content part

---------

Co-authored-by: Halvor Haugan <halvor.haugan@nav.no>
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
@JulianNymark JulianNymark marked this pull request as draft November 19, 2024 14:10
@JulianNymark JulianNymark changed the title 🚧 [Darkside] datemonthpicker [Darkside] datemonthpicker Nov 19, 2024
@JulianNymark
Copy link
Contributor Author

Right now it has a blue border on hover (even in error state) maybe it shouldn't be like this on error? 🤔 (though it's nice to have a hover indicator).

@JulianNymark JulianNymark marked this pull request as ready for review November 21, 2024 10:24
@navikt/core/css/darkside/form/index.css Outdated Show resolved Hide resolved
@navikt/core/css/darkside/date.darkside.css Outdated Show resolved Hide resolved
@navikt/core/css/darkside/date.darkside.css Show resolved Hide resolved
@navikt/core/css/darkside/date.darkside.css Outdated Show resolved Hide resolved
@navikt/core/css/darkside/date.darkside.css Outdated Show resolved Hide resolved
@navikt/core/css/darkside/date.darkside.css Outdated Show resolved Hide resolved
@navikt/core/css/darkside/date.darkside.css Outdated Show resolved Hide resolved
@navikt/core/css/darkside/date.darkside.css Outdated Show resolved Hide resolved
@navikt/core/css/darkside/form/index.css Outdated Show resolved Hide resolved
Copy link
Collaborator

@KenAJoh KenAJoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JulianNymark JulianNymark merged commit 8ea6c22 into main Dec 3, 2024
4 checks passed
@JulianNymark JulianNymark deleted the darkside-datemonthpicker branch December 3, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants