[Darkside] Loader CSS update

[KenAJoh]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: a6ca8b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

Storybook demo

6acbd0937 | 91 komponenter | 135 stories

[HalvorHaugan]

Still WIP?

[KenAJoh]

Member

No, should be good-to-go

[HalvorHaugan]

Why nest this?

[KenAJoh]

Personally like to have changes in local tokens before it is used --__axc-loader-stroke-width. Feels disorienting to have "definition -> use -> definition -> definition" in some cases. But for a short file like this it doesn't really matter

[HalvorHaugan]

I think you misunderstand. I'm wondering why you put &.navds-loader--3xlarge etc. inside .navds-loader {?
Do you need the selector to be .navds-loader.navds-loader--3xlarge?

[HalvorHaugan]

I get some weird shaking in Chrome 😅

shaky.loaders.mp4

Only seems to happen when there are multiple loaders, so I don't think we need to worry about it.

[KenAJoh]

I get some weird shaking in Chrome 😅

@HalvorHaugan Is this new in this PR, or the case with the old loader to?

[HalvorHaugan]

Only with the new darkside css in this PR

[KenAJoh]

@HalvorHaugan So strange, no changes were made to how this were handled 🤔 Does it change if you remove stroke-linecap: round; in this CSS? That should be the only actual change

.navds-loader__foreground {
  animation: loader-dasharray 1.5s ease-in-out infinite;
  stroke-dasharray: 80px, 200px;
  stroke-dashoffset: 0;
  stroke: var(--ax-border-strong);
  stroke-linecap: round;
}

[HalvorHaugan]

@KenAJoh Yes, it doesn't happen if I remove stroke-linecap 😅 It doesn't happen on my personal computer though, so it's probably just something weird with my work computer 😅 I wonder what it could be though, because it happens in incognito as well as in Chrome Beta, Canary and Dev too 🙃