[Linting] Update @typescript-eslint/eslint-plugin to v8 (#3222)

* linting: update ts eslint package to v8 * linting: Update ts eslint package to v8 * change: removed redundant off-toggle of native eslint rules * change: update interface declaration
navikt · Oct 14, 2024 · 2e98a09 · 2e98a09
1 parent 2d438e1
commit 2e98a09
Show file tree

Hide file tree

Showing 19 changed files with 116 additions and 124 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -77,6 +77,11 @@ module.exports = {
         "@typescript-eslint/no-shadow": ["error", { hoist: "all" }],
         "@typescript-eslint/no-explicit-any": "off", // Temporary
         "@typescript-eslint/array-type": "error",
+        "@typescript-eslint/no-unused-expressions": [
+          "error",
+          /* https://eslint.org/docs/latest/rules/no-unused-expressions#allowshortcircuit-and-allowternary */
+          { allowShortCircuit: true, allowTernary: true },
+        ],
       },
     },
     {

diff --git a/@navikt/core/react/src/modal/dialog-polyfill.ts b/@navikt/core/react/src/modal/dialog-polyfill.ts
@@ -518,7 +518,7 @@ dialogPolyfill.isInlinePositionSetByStylesheet = function (element) {
     // Some browsers throw on cssRules.
     try {
       cssRules = styleSheet.cssRules;
-    } catch (e) {
+    } catch {
       /* empty */
     }
     if (!cssRules) {
@@ -530,7 +530,7 @@ dialogPolyfill.isInlinePositionSetByStylesheet = function (element) {
       // Ignore errors on invalid selector texts.
       try {
         selectedNodes = document.querySelectorAll(rule.selectorText);
-      } catch (e) {
+      } catch {
         /* empty */
       }
       if (!selectedNodes || !inNodeList(selectedNodes, element)) {

diff --git a/@navikt/core/react/src/overlays/action-menu/ActionMenu.tsx b/@navikt/core/react/src/overlays/action-menu/ActionMenu.tsx
@@ -808,7 +808,7 @@ const ActionMenuRadioItem = forwardRef<
 /* -------------------------------------------------------------------------- */
 type ActionMenuDividerElement = React.ElementRef<typeof Menu.Divider>;
 type MenuDividerProps = React.ComponentPropsWithoutRef<typeof Menu.Divider>;
-interface ActionMenuDividerProps extends Omit<MenuDividerProps, "asChild"> {}
+type ActionMenuDividerProps = Omit<MenuDividerProps, "asChild">;
 
 const ActionMenuDivider = forwardRef<
   ActionMenuDividerElement,

diff --git a/@navikt/core/react/src/overlays/floating-menu/Menu.tsx b/@navikt/core/react/src/overlays/floating-menu/Menu.tsx
@@ -173,7 +173,7 @@ const MenuAnchor = forwardRef<MenuAnchorElement, MenuAnchorProps>(
 /*                                Menu Content                                */
 /* -------------------------------------------------------------------------- */
 type MenuContentElement = MenuContentInternalElement;
-interface MenuContentProps extends MenuContentInternalTypeProps {}
+type MenuContentProps = MenuContentInternalTypeProps;
 
 const MenuContent = React.forwardRef<
   MenuContentInternalElement,
@@ -370,11 +370,10 @@ const MenuContentInternal = forwardRef<
   },
 );
 
-interface MenuContentInternalTypeProps
-  extends Omit<
-    MenuContentInternalProps,
-    keyof MenuContentInternalPrivateProps
-  > {}
+type MenuContentInternalTypeProps = Omit<
+  MenuContentInternalProps,
+  keyof MenuContentInternalPrivateProps
+>;
 
 /* -------------------------------------------------------------------------- */
 /*                                  Menu item                                 */
@@ -560,7 +559,7 @@ const MenuItemInternal = forwardRef<
 /* -------------------------------------------------------------------------- */
 /*                                  Menu Group                                 */
 /* -------------------------------------------------------------------------- */
-interface MenuGroupProps extends SlottedDivProps {}
+type MenuGroupProps = SlottedDivProps;
 
 const MenuGroup = forwardRef<SlottedDivElementRef, MenuGroupProps>(
   (props: MenuGroupProps, ref) => {
@@ -634,7 +633,7 @@ const [MenuItemIndicatorProvider, useMenuItemIndicatorContext] = createContext<{
   hookName: "useMenuItemIndicatorContext",
 });
 
-interface MenuItemIndicatorProps extends SlottedDivProps {}
+type MenuItemIndicatorProps = SlottedDivProps;
 
 const MenuItemIndicator = forwardRef<
   SlottedDivElementRef,
@@ -726,7 +725,7 @@ const MenuCheckboxItem = forwardRef<MenuItemElement, MenuCheckboxItemProps>(
 /* -------------------------------------------------------------------------- */
 /*                               Menu Divider                               */
 /* -------------------------------------------------------------------------- */
-interface MenuDividerProps extends SlottedDivProps {}
+type MenuDividerProps = SlottedDivProps;
 
 const MenuDivider = forwardRef<SlottedDivElementRef, MenuDividerProps>(
   (props: MenuDividerProps, ref) => {
@@ -821,7 +820,7 @@ const MenuSub: React.FC<MenuSubProps> = ({
 /* -------------------------------------------------------------------------- */
 /*                            Menu SubMenu Trigger                            */
 /* -------------------------------------------------------------------------- */
-interface MenuSubTriggerProps extends MenuItemInternalProps {}
+type MenuSubTriggerProps = MenuItemInternalProps;
 
 const MenuSubTrigger = forwardRef<MenuItemElement, MenuSubTriggerProps>(
   (props: MenuSubTriggerProps, forwardedRef) => {
@@ -885,15 +884,14 @@ const MenuSubTrigger = forwardRef<MenuItemElement, MenuSubTriggerProps>(
 /* -------------------------------------------------------------------------- */
 /*                            Menu SubMenu Content                            */
 /* -------------------------------------------------------------------------- */
-interface MenuSubContentProps
-  extends Omit<
-    MenuContentInternalProps,
-    | keyof MenuContentInternalPrivateProps
-    | "onCloseAutoFocus"
-    | "onEntryFocus"
-    | "side"
-    | "align"
-  > {}
+type MenuSubContentProps = Omit<
+  MenuContentInternalProps,
+  | keyof MenuContentInternalPrivateProps
+  | "onCloseAutoFocus"
+  | "onEntryFocus"
+  | "side"
+  | "align"
+>;
 
 const MenuSubContent = forwardRef<
   MenuContentInternalElement,

diff --git a/@navikt/core/react/src/overlays/floating/Floating.utils.ts b/@navikt/core/react/src/overlays/floating/Floating.utils.ts
@@ -1,10 +1,7 @@
 import type { Middleware, Placement } from "@floating-ui/react-dom";
 
-const SIDE_OPTIONS = ["top", "right", "bottom", "left"] as const;
-const ALIGN_OPTIONS = ["start", "center", "end"] as const;
-
-type Side = (typeof SIDE_OPTIONS)[number];
-type Align = (typeof ALIGN_OPTIONS)[number];
+type Side = "top" | "right" | "bottom" | "left";
+type Align = "start" | "center" | "end";
 type Measurable = { getBoundingClientRect(): DOMRect };
 
 /**

diff --git a/@navikt/core/react/src/table/Body.tsx b/@navikt/core/react/src/table/Body.tsx
@@ -1,13 +1,11 @@
 import cl from "clsx";
 import React, { forwardRef } from "react";
 
-export interface BodyProps
-  extends React.HTMLAttributes<HTMLTableSectionElement> {}
+export type BodyProps = React.HTMLAttributes<HTMLTableSectionElement>;
 
-export interface BodyType
-  extends React.ForwardRefExoticComponent<
-    BodyProps & React.RefAttributes<HTMLTableSectionElement>
-  > {}
+export type BodyType = React.ForwardRefExoticComponent<
+  BodyProps & React.RefAttributes<HTMLTableSectionElement>
+>;
 
 export const Body: BodyType = forwardRef(({ className, ...rest }, ref) => (
   <tbody {...rest} ref={ref} className={cl("navds-table__body", className)} />

diff --git a/@navikt/core/react/src/table/ColumnHeader.tsx b/@navikt/core/react/src/table/ColumnHeader.tsx
@@ -19,10 +19,9 @@ export interface ColumnHeaderProps extends HeaderCellProps {
   sortable?: boolean;
 }
 
-export interface ColumnHeaderType
-  extends React.ForwardRefExoticComponent<
-    ColumnHeaderProps & React.RefAttributes<HTMLTableCellElement>
-  > {}
+export type ColumnHeaderType = React.ForwardRefExoticComponent<
+  ColumnHeaderProps & React.RefAttributes<HTMLTableCellElement>
+>;
 
 export const ColumnHeader: ColumnHeaderType = forwardRef(
   ({ className, children, sortable = false, sortKey, ...rest }, ref) => {

diff --git a/@navikt/core/react/src/table/ExpandableRow.tsx b/@navikt/core/react/src/table/ExpandableRow.tsx
@@ -49,10 +49,9 @@ export interface ExpandableRowProps extends Omit<RowProps, "content"> {
   colSpan?: number;
 }
 
-export interface ExpandableRowType
-  extends React.ForwardRefExoticComponent<
-    ExpandableRowProps & React.RefAttributes<HTMLTableRowElement>
-  > {}
+export type ExpandableRowType = React.ForwardRefExoticComponent<
+  ExpandableRowProps & React.RefAttributes<HTMLTableRowElement>
+>;
 
 export const ExpandableRow: ExpandableRowType = forwardRef(
   (

diff --git a/@navikt/core/react/src/table/Header.tsx b/@navikt/core/react/src/table/Header.tsx
@@ -1,13 +1,11 @@
 import cl from "clsx";
 import React, { forwardRef } from "react";
 
-export interface HeaderProps
-  extends React.HTMLAttributes<HTMLTableSectionElement> {}
+export type HeaderProps = React.HTMLAttributes<HTMLTableSectionElement>;
 
-export interface HeaderType
-  extends React.ForwardRefExoticComponent<
-    HeaderProps & React.RefAttributes<HTMLTableSectionElement>
-  > {}
+export type HeaderType = React.ForwardRefExoticComponent<
+  HeaderProps & React.RefAttributes<HTMLTableSectionElement>
+>;
 
 export const Header: HeaderType = forwardRef(({ className, ...rest }, ref) => (
   <thead {...rest} ref={ref} className={cl("navds-table__header", className)} />

diff --git a/@navikt/core/react/src/table/HeaderCell.tsx b/@navikt/core/react/src/table/HeaderCell.tsx
@@ -15,10 +15,9 @@ export interface HeaderCellProps
   textSize?: "medium" | "small";
 }
 
-export interface HeaderCellType
-  extends React.ForwardRefExoticComponent<
-    HeaderCellProps & React.RefAttributes<HTMLTableCellElement>
-  > {}
+export type HeaderCellType = React.ForwardRefExoticComponent<
+  HeaderCellProps & React.RefAttributes<HTMLTableCellElement>
+>;
 
 export const HeaderCell: HeaderCellType = forwardRef(
   ({ className, children, align, textSize, ...rest }, ref) => {

diff --git a/@navikt/core/react/src/table/Row.tsx b/@navikt/core/react/src/table/Row.tsx
@@ -14,10 +14,9 @@ export interface RowProps extends React.HTMLAttributes<HTMLTableRowElement> {
   shadeOnHover?: boolean;
 }
 
-export interface RowType
-  extends React.ForwardRefExoticComponent<
-    RowProps & React.RefAttributes<HTMLTableRowElement>
-  > {}
+export type RowType = React.ForwardRefExoticComponent<
+  RowProps & React.RefAttributes<HTMLTableRowElement>
+>;
 
 export const Row: RowType = forwardRef(
   ({ className, selected = false, shadeOnHover = true, ...rest }, ref) => (

diff --git a/@navikt/core/react/src/util/virtualfocus/parts/VirtualFocusContent.tsx b/@navikt/core/react/src/util/virtualfocus/parts/VirtualFocusContent.tsx
@@ -1,8 +1,10 @@
 import React, { forwardRef } from "react";
 import { useVirtualFocusInternalContext } from "../Context";
 
-export interface VirtualFocusContentProps
-  extends Omit<React.HTMLAttributes<HTMLDivElement>, "id"> {}
+export type VirtualFocusContentProps = Omit<
+  React.HTMLAttributes<HTMLDivElement>,
+  "id"
+>;
 
 export const VirtualFocusContent = forwardRef<
   HTMLDivElement,

diff --git a/aksel.nav.no/website/components/hooks/useCheckAuth.ts b/aksel.nav.no/website/components/hooks/useCheckAuth.ts
@@ -18,7 +18,7 @@ export const useCheckAuth = (skipCheck?: boolean) => {
       try {
         setUser(!!JSON.parse(response)?.id);
         return;
-      } catch (e) {
+      } catch {
         setUser(false);
       }
       setUser(false);

diff --git a/aksel.nav.no/website/middleware.ts b/aksel.nav.no/website/middleware.ts
@@ -57,7 +57,7 @@ export async function middleware(req: NextRequest) {
     }
 
     return NextResponse.next();
-  } catch (e) {
+  } catch {
     return NextResponse.next();
   }
 }

diff --git a/aksel.nav.no/website/sanity/schema/documents/presets/editors.ts b/aksel.nav.no/website/sanity/schema/documents/presets/editors.ts
@@ -34,7 +34,7 @@ export const editorField = defineField({
           email: currentUser.email,
           title: currentUser.name,
         });
-      } catch (error) {
+      } catch {
         const { logger } = await import("@navikt/next-logger");
         logger.error({
           message: "Failed to create sanity profile for user.",

diff --git a/aksel.nav.no/website/scripts/update-examples/parts/extract-metadata.ts b/aksel.nav.no/website/scripts/update-examples/parts/extract-metadata.ts
@@ -27,7 +27,7 @@ export function extractMetadata(
 
   try {
     return JSON5.parse(metadata);
-  } catch (e) {
+  } catch {
     console.error(`Could not parse JSON5 in ${dirName}`);
   }
 }
diff --git a/aksel.nav.no/website/scripts/update-examples/parts/validate-examples.ts b/aksel.nav.no/website/scripts/update-examples/parts/validate-examples.ts
@@ -33,7 +33,7 @@ export function validateExamples(exampleData: ExampleDataT[]) {
   try {
     const cmd = `yarn tsc --noEmit --noUnusedLocals true --incremental false -p ${tempTsConfigFile}`;
     execSync(cmd, { stdio: "inherit" }); // Setting stdio to inherit makes the output visible in the console
-  } catch (e) {
+  } catch {
     success = false;
   }
 

diff --git a/package.json b/package.json
@@ -160,8 +160,8 @@
     "@storybook/theming": "^8.3.4",
     "@svitejs/changesets-changelog-github-compact": "^1.1.0",
     "@trivago/prettier-plugin-sort-imports": "^4.3.0",
-    "@typescript-eslint/eslint-plugin": "^7.18.0",
-    "@typescript-eslint/parser": "^7.18.0",
+    "@typescript-eslint/eslint-plugin": "^8.8.1",
+    "@typescript-eslint/parser": "^8.8.1",
     "@vitest/eslint-plugin": "^1.1.4",
     "@whitespace/storybook-addon-html": "^6.1.1",
     "chromatic": "11.5.4",