Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #846, repo provided_contents check for gc settings from repo #852

Merged
merged 2 commits into from
Feb 6, 2025
Merged

fix #846, repo provided_contents check for gc settings from repo #852

merged 2 commits into from
Feb 6, 2025

Conversation

jeffkala
Copy link
Contributor

No description provided.

@jeffkala
Copy link
Contributor Author

Still need to do some further testing before this can be merged.

@jeffkala
Copy link
Contributor Author

jeffkala commented Feb 3, 2025

Testing seems good.

  1. When the provides isn't selected (it skips... it didn't do this before)
    Screenshot 2025-02-03 at 10 34 36 AM

  2. When it is selected it properly syncs in the properties.
    Screenshot 2025-02-03 at 10 35 05 AM

@jeffkala
Copy link
Contributor Author

jeffkala commented Feb 3, 2025

This is ready for a review @itdependsnetworks

@jeffkala jeffkala merged commit 7afe199 into develop Feb 6, 2025
15 checks passed
@jeffkala jeffkala deleted the jlk-fix-846 branch February 6, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itdependsnetworks itdependsnetworks itdependsnetworks approved these changes

@nkallergis nkallergis Awaiting requested review from nkallergis nkallergis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffkala @itdependsnetworks