-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPG Awesome Redux #3420
RPG Awesome Redux #3420
Conversation
i.e., "d2, d6, d8, d10, d12, d20", not "d10, d12, d2, d20, d6, d8"
This branch just does the same thing as the RPG Awesome repo, but more closely aligns with the code used in the other icon fonts and isn't an NPM package.
Hi, thanks for your contribution to the Homebrewery! You already have >=3 open pull requests. Consider completing some of your existing PRs before opening new ones. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gazook89 I just merged the Emojis PR. Do you want to rebase this on top of master? There are a few conflicts since some of the files over there were changed. Otherwise I think this is basically fine. Just need to handle the merge conflicts.
@calculuschild i did the merge, pretty sure I got it right but did have to fix a couple things in a later commit (duplicated a file, and missed some references to my font). It works. In Gitter I did raise a license issue which might be a downer. Basically, I didn't realize when I started that each glyph requires attribution per game-icons.net, and that the attribution is different between different glyphs. Options I see are 1) seek alternate license, 2) mass attribution of all authors on a FAQ-like page and encourage users to attribute in their brews, or 3) drop the PR. Or, some system where the creator of each icon is held in the gameIcons.js file, turning the 'values' of each icon from strings to objects ( |
Just noting here I have reached out to game-icons via email to ask about the licensing question on May 16, 2024. No response yet. However, I believe something like this may be sufficient:
|
I am going to work on merging this. I am fairly confident the licensing thing won't be an issue if we link to the authors page on Game-Icons. However, we should add an easy method for users to insert the appropriate attribution/licenses for any fonts/icons included in the document. Perhaps as a separate PR in the vein of #3090 |
This branch just does the same thing as the RPG Awesome repo, but more closely aligns with the code used in the other icon fonts and isn't an NPM package. It was a 'proof of concept' to see what it takes to get the icons from Game-Icons.net rolled into a font package.
I used icomoon.io as suggested in the RA repo (actually the companion repo listed in it's readme), but skipped everything in the actual RA repo....
Anyway, point being, this process could now easily include other symbols from Game-Icons.net. Process would be:
theoretically, this could be done for ALL of game icons library— they have a download file that includes their whole library, and icomoon.io does batch upload and download.
(this is a PR on your open branch again...this one might be easier to just merge into your branch, or you could download the woff and .less file and just fold into your code if you prefer, if approved at all).