Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override onStatusChanged to be compatible with Android <29 #15

Merged
merged 3 commits into from
May 16, 2024

Conversation

pamafe1976
Copy link
Contributor

This is to fix issue #14

@natsuk4ze natsuk4ze self-requested a review May 15, 2024 23:43
Copy link
Owner

@natsuk4ze natsuk4ze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation warning that appears on Android 29 and above needs to be removed like a geolocator

Copy link
Contributor Author

@pamafe1976 pamafe1976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason I'm not seeing the warning, so please check if this clears it for you

Copy link
Contributor Author

@pamafe1976 pamafe1976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot import

Copy link
Owner

@natsuk4ze natsuk4ze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natsuk4ze natsuk4ze merged commit 35c68e3 into natsuk4ze:main May 16, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants