Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FA brand icons, header and footer optimisation #91

Merged
merged 10 commits into from
Feb 27, 2024
Merged

Remove FA brand icons, header and footer optimisation #91

merged 10 commits into from
Feb 27, 2024

Conversation

ahosgood
Copy link
Member

Changed

  • Footer social links structure and HTML changed
  • Header icons changed to SVGs
  • Crown logo in footer changed from St Edward's Crown to Tudor Crown
  • Added navigation toggle button to HTML of both headers
  • Allow navigation groups in footer to have hidden titles
  • utilities/_global.scss split into other files _reset.scss and _areas.scss

Removed

  • Removed option for brand icons on buttons, card actions and headers
  • Removed Font Awesome icon selection for header and footers
  • No init method for component JavaScript - components are now initialised on instantiation (new Header($header).init() -> new Header($header))

@ahosgood ahosgood enabled auto-merge (squash) February 27, 2024 14:44
@ahosgood ahosgood merged commit b843c13 into main Feb 27, 2024
8 checks passed
@ahosgood ahosgood deleted the feature/remove-fa-brand-icons branch February 27, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ahosgood