Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacing refactor #108

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Spacing refactor #108

merged 3 commits into from
Mar 22, 2024

Conversation

ahosgood
Copy link
Member

Added

  • Spacing can now be defined in relative terms (e.g. 1, 3, 0.25) which is converted to absolute values

Changed

  • Changed grid dimensions (max width, gutters etc.) from rem units to px
  • Changed all spacing (margin, padding and gap) to use spacing.space() tool for relative sizes

Removed

  • Removed strapline option for global header

Fixed

  • Removed explicit font size on tna-template allowing browser-defined font sizes

@ahosgood ahosgood enabled auto-merge (squash) March 22, 2024 14:01
@ahosgood ahosgood merged commit 4e8127a into main Mar 22, 2024
9 checks passed
@ahosgood ahosgood deleted the feature/spacing-updates branch March 22, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ahosgood