From edf87989362119d5ca28e45ddd574e32a8010b6e Mon Sep 17 00:00:00 2001 From: Andrew Hosgood Date: Mon, 16 Sep 2024 12:12:06 +0100 Subject: [PATCH] Update the default aria-label on breadcrumbs components --- CHANGELOG.md | 3 +++ .../components/breadcrumbs/fixtures.json | 10 +++++----- .../components/breadcrumbs/template.njk | 2 +- src/nationalarchives/templates/fixtures.json | 6 +++--- 4 files changed, 12 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8a627c0a..e1a3660d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Added ### Changed + +- Updated the default `aria-label` on breadcrumbs components from "Breadcrumb" to "Breadcrumbs" + ### Deprecated ### Removed ### Fixed diff --git a/src/nationalarchives/components/breadcrumbs/fixtures.json b/src/nationalarchives/components/breadcrumbs/fixtures.json index 19744e4b..634518f9 100644 --- a/src/nationalarchives/components/breadcrumbs/fixtures.json +++ b/src/nationalarchives/components/breadcrumbs/fixtures.json @@ -19,7 +19,7 @@ } ] }, - "html": "" + "html": "" }, { "name": "non-collapsing", @@ -40,7 +40,7 @@ ], "noCollapse": true }, - "html": "" + "html": "" }, { "name": "Structured data", @@ -61,7 +61,7 @@ ], "structuredData": true }, - "html": "" + "html": "" }, { "name": "with classes", @@ -82,7 +82,7 @@ ], "classes": "tna-breadcrumbs--test" }, - "html": "" + "html": "" }, { "name": "with attributes", @@ -105,7 +105,7 @@ "data-testattribute": "foobar" } }, - "html": "" + "html": "" } ] } diff --git a/src/nationalarchives/components/breadcrumbs/template.njk b/src/nationalarchives/components/breadcrumbs/template.njk index 44fa90d4..35777132 100644 --- a/src/nationalarchives/components/breadcrumbs/template.njk +++ b/src/nationalarchives/components/breadcrumbs/template.njk @@ -3,7 +3,7 @@ {%- set containerClasses = containerClasses.concat('tna-breadcrumbs--no-collapse') -%} {%- endif -%} {%- set classes = containerClasses | join(' ') -%} -