Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Configured lossy_bitrate not used #823

Open
cs-t1 opened this issue Mar 12, 2025 · 2 comments · May be fixed by #834
Open

[BUG] Configured lossy_bitrate not used #823

cs-t1 opened this issue Mar 12, 2025 · 2 comments · May be fixed by #834
Labels
bug Something isn't working

Comments

@cs-t1
Copy link

cs-t1 commented Mar 12, 2025

Describe the bug

I'm having the issue of ffmpeg not been given the correct bitrate flag for song conversion. Upon reading through the code, it seems to me that the lossy_bitrate field in the config file is never used, thus the conversion engine using its default value (-q:a 0)

Thanks :)

Command Used

rip --quality 1 --folder . url <url>

Debug Traceback

Not applicable

Config File

# Convert tracks to a codec after downloading them.
[conversion]
enabled = true
# FLAC, ALAC, OPUS, MP3, VORBIS, or AAC
codec = "MP3"
# In Hz. Tracks are downsampled if their sampling rate is greater than this. 
# Value of 48000 is recommended to maximize quality and minimize space
sampling_rate = 48000
# Only 16 and 24 are available. It is only applied when the bit depth is higher
# than this value.
bit_depth = 24
# Only applicable for lossy codecs
lossy_bitrate = 320

Operating System

Linux

streamrip version

2.0.5

Screenshots and recordings

No response

Additional context

No response

@cs-t1 cs-t1 added the bug Something isn't working label Mar 12, 2025
@Louis2530
Copy link
Contributor

Working on it, if you specify quality, it "override" config convert option ans take the raw file quality from service
But when you specify a codec or you enable convertion in config, streamrip don't convert the file, it's strange

@cs-t1
Copy link
Author

cs-t1 commented Mar 22, 2025

Well, I did get streamrip to convert the files to mp3, however the target bitrate is incorrect. In fact, the issue lies in the bitrate configuration never been read and the default one being passed to ffmpeg.

@cs-t1 cs-t1 linked a pull request Mar 22, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants