namespace click handlers #310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @nathanvda Thank you |
|
Is this PR still relevant? I was hesitant to merge since I did not (still do not) completely understand the need for this. Although on the other hand this merge is completely safe/backwards compatible, right? Also I am thinking this might have been fueled by incorrrect/incomplete turbolinks behaviour, which should be ok now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace click event handlers to allow specific binding / unbinding of cocoon. Also fixes issues you may encounter with things like https://github.com/gemgento/rails_script removing bindings on page load/change.