-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build break for zig 0.14.0-dev.2596 #131
Fix build break for zig 0.14.0-dev.2596 #131
Conversation
I think CI is not testing luajit. But at least my superficial attempt to look at it failed on Windows, so it might not work to enable it in the makefile with the current GitHub Actions config. |
The |
Thanks! I'll update the PR to use |
- There's no root_module.addCMacro anymore - There's also no root_module.unwind_tables boolean anymore. Setting "unwind_tables = .sync" should match earlier behavior. for natecraddock#130
2233e8f
to
3d36e37
Compare
PR updated to use |
Not working until natecraddock/ziglua#131 is merged
I think this issue is still unresolved. Neither this nor the change mentioned above is in. |
+ this includes fixing things to enable running "zig build test" for natecraddock#130
@natecraddock AFAIC this PR is good to go. I checked that it also implements what was pointed out in the above comment but also adds some fixes to newer zig versions. I also snuck in a new test for pushAny of an anonymous struct. I didn't see one in the existing tests, and that was the usage pattern in my code where I noticed these new breakages. |
Hi! So sorry for the long delays and silence. Life has been crazy Thanks for working on this |
There's no root_module.addCMacro anymore
There's also no root_module.unwind_tables boolean anymore. My fix only fixes the break but I don't know what's the right value to set here. The choices are null, sync, and async. I couldn't get the luajit variant to build on Windows. Maybe merge this and ask the luajit contributor for a proper fix?
for #130