TRT-571 - Update regression tests for net2cog. #131
Conversation
There was a problem hiding this comment.
I was able to pull and build the service image for net2cog from the branch in the instructions, I spun up Harmony-In-A-Box and ran this notebook against it and all of the tests passed.
Only one comment about expected metadata looking like it's coming from the actual data. You could make the small change suggested, but I don't have strong opinions.
test/net2cog/utility.py
Outdated
| print(f'Assessing: {basename(cog_file)}') | ||
| validate_cog(cog_file) | ||
|
|
||
| expected_metadata = { |
There was a problem hiding this comment.
this is actual metadata isn't it? if those are downloaded_cog_outputs.
There was a problem hiding this comment.
I think this should go down below the reference_file and get the dtype and nodata from the reference file. Because when you check in assert_dataset_produced_correct_results you're just checking against the file you got the expected from.
There was a problem hiding this comment.
Ok, I just looked at the functions for get_expected_smap_dtype and get_expected_smap_nodata, so this is really not a big deal, since it's reading the filename not any actual data. But it is a little confusing
There was a problem hiding this comment.
Yeah, so they are just looking at the file name to determine the variable that is in it and set the right values. But it's a great point - the better thing to do would be to pull the values from the reference file, rather than make inferences based on the file name. I'll take a look at that now.
There was a problem hiding this comment.
Here we go: 7bc51b
This feels much cleaner.
Description
This PR updates the net2cog regression test suite to cover two cases for multiple variables:
To enable multiple variables (due to the need for multiple UMM-Var records), I cloned the SMAP collection already being used into the EEDTEST provider in UAT and the tests now use those files.
The corresponding changes to the services are in podaac/net2cog#38.
Notes: The test data use
git lfs, so when running this notebook locally you will need to grab those files usinggit lfs.Jira Issue ID
This work is in support of TRT-571, and addresses GitHub issue podaac/net2cog#32, and part of podaac/net2cog#35.
Local Test Steps
.envfile.conda env create -f ./environment.yaml).conda activate papermill-net2cog).harmony_host_url = 'http://localhost:3000'). The notebook is set to UAT as a default.PR Acceptance Checklist