Merge pull request #116 from nasa/trade-187-sambah-tests

TRADE-187: Add tests for SAMBAH
nasa · Feb 21, 2025 · 9d7cfe9 · 9d7cfe9
2 parents ea8836e + 2e80db0
commit 9d7cfe9
Show file tree

Hide file tree

Showing 14 changed files with 530 additions and 6 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -1,5 +1,9 @@
 test/nsidc-icesat2/reference_files/*.h5 filter=lfs diff=lfs merge=lfs -text
 test/subset-band-name/reference_data/*.hdf filter=lfs diff=lfs merge=lfs -text
+test/sambah/reference_files/all_data.nc4 filter=lfs diff=lfs merge=lfs -text
+test/sambah/reference_files/spatial_only.nc4 filter=lfs diff=lfs merge=lfs -text
+test/sambah/reference_files/temp_var_bbox.nc4 filter=lfs diff=lfs merge=lfs -text
+test/sambah/reference_files/var_only.nc4 filter=lfs diff=lfs merge=lfs -text
 test/opera-rtc-s1-browse/reference_data/*.png filter=lfs diff=lfs merge=lfs -text
 test/hybig/reference_data/**/*.png filter=lfs diff=lfs merge=lfs -text
 test/hybig/reference_data/**/*.jpg filter=lfs diff=lfs merge=lfs -text

diff --git a/.github/workflows/build-all-images.yml b/.github/workflows/build-all-images.yml
@@ -64,6 +64,11 @@ jobs:
           -
             image: "net2cog"
             notebook: "net2cog_Regression.ipynb"
+          -
+            image: "sambah"
+            notebook: "SAMBAH_Regression.ipynb"
+            shared-utils: "true"
+            lfs: "true"
           -
             image: "opera-rtc-s1-browse"
             notebook: "opera-rtc-s1-browse_Regression.ipynb"

diff --git a/config/services_tests_config_prod.json b/config/services_tests_config_prod.json
@@ -1,6 +1,6 @@
 {
-  "all": "harmony,harmony-regression,geoloco,hga,n2z,regridder,hoss,hybig,net2cog,smap-l2-gridder,subset-band-name,swath-projector,nsidc-icesat2,trajectory-subsetter,opera-rtc-s1-browse",
-  "batchee": "TBD",
+  "all": "harmony,harmony-regression,geoloco,hga,n2z,regridder,hoss,hybig,net2cog,smap-l2-gridder,subset-band-name,swath-projector,nsidc-icesat2,trajectory-subsetter,sambah,opera-rtc-s1-browse",
+  "batchee": "sambah",
   "geoloco": "geoloco",
   "giovanni-adapter": "TBD",
   "harmony-gdal-adapter": "hga",
@@ -15,7 +15,7 @@
   "query-cmr": "geoloco",
   "smap-l2-gridder": "smap-l2-gridder",
   "sds-maskfill": "TBD",
-  "stitchee": "TBD",
+  "stitchee": "sambah",
   "subset-band-name": "subset-band-name",
   "swath-projector": "swath-projector",
   "trajectory-subsetter": "nsidc-icesat2,trajectory-subsetter",

diff --git a/config/services_tests_config_uat.json b/config/services_tests_config_uat.json
@@ -1,6 +1,6 @@
 {
-  "all": "harmony,harmony-regression,geoloco,hga,n2z,regridder,hoss,variable-subsetter,hybig,net2cog,smap-l2-gridder,subset-band-name,swath-projector,nsidc-icesat2,trajectory-subsetter,opera-rtc-s1-browse",
-  "batchee": "TBD",
+  "all": "harmony,harmony-regression,geoloco,hga,n2z,regridder,hoss,variable-subsetter,hybig,net2cog,smap-l2-gridder,subset-band-name,swath-projector,nsidc-icesat2,trajectory-subsetter,sambah,opera-rtc-s1-browse",
+  "batchee": "sambah",
   "geoloco": "geoloco",
   "giovanni-adapter": "TBD",
   "harmony-gdal-adapter": "hga",
@@ -15,7 +15,7 @@
   "query-cmr": "variable-subsetter",
   "smap-l2-gridder": "smap-l2-gridder",
   "sds-maskfill": "TBD",
-  "stitchee": "TBD",
+  "stitchee": "sambah",
   "subset-band-name": "subset-band-name",
   "swath-projector": "swath-projector",
   "trajectory-subsetter": "nsidc-icesat2,trajectory-subsetter",

diff --git a/script/test-in-bamboo.sh b/script/test-in-bamboo.sh
@@ -54,6 +54,7 @@ all_tests=(
     nsidc-icesat2
     opera-rtc-s1-browse
     regridder
+    sambah
     smap-l2-gridder
     subset-band-name
     swath-projector

diff --git a/test/Makefile b/test/Makefile
@@ -62,6 +62,11 @@ net2cog-image: Dockerfile net2cog/environment.yaml
 	docker build -t ghcr.io/nasa/regression-tests-net2cog:latest -f ./Dockerfile \
 	--build-arg notebook=net2cog_Regression.ipynb --build-arg sub_dir=net2cog .
 
+sambah-image: Dockerfile sambah/environment.yaml
+	docker build -t ghcr.io/nasa/regression-tests-sambah:latest -f ./Dockerfile \
+	--build-arg notebook=SAMBAH_Regression.ipynb --build-arg sub_dir=sambah \
+	--build-arg shared_utils=true .
+
 opera-rtc-s1-browse-image: Dockerfile opera-rtc-s1-browse/environment.yaml
 	docker build -t ghcr.io/nasa/regression-tests-opera-rtc-s1-browse:latest -f ./Dockerfile \
 	--build-arg notebook=opera-rtc-s1-browse_Regression.ipynb --build-arg sub_dir=opera-rtc-s1-browse .
@@ -81,4 +86,5 @@ images: harmony-image \
 	variable-subsetter-image \
 	geoloco-image \
 	net2cog-image \
+	sambah-image \
 	opera-rtc-s1-browse-image
diff --git a/test/run_notebooks.sh b/test/run_notebooks.sh
@@ -27,6 +27,7 @@ all_images=(
     nsidc-icesat2
     opera-rtc-s1-browse
     regridder
+    sambah
     smap-l2-gridder
     subset-band-name
     swath-projector