Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUMULUS-3892: Update the home page metrics overview section #1154

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Nnaga1
Copy link
Contributor

@Nnaga1 Nnaga1 commented Oct 16, 2024

Summary: Summary of changes

Addresses CUMULUS-3892: Dashboard - Home Page Metrics Overview Section Update

Changes

  • Code: Update timeframe to the past 24 hours
  • UI: Add a label to inform user of the timeframe

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Adhoc testing
  • Integration tests

@Nnaga1 Nnaga1 added the Needs Review Looking for a reviewer label Oct 16, 2024
@jjmccoy jjmccoy self-assigned this Oct 16, 2024
@jjmccoy jjmccoy added In Review and removed Needs Review Looking for a reviewer labels Oct 16, 2024
@jjmccoy
Copy link
Member

jjmccoy commented Oct 16, 2024

@Nnaga1 This looks good. I believe there is a cypress test for the home page: main_page_spec.js. That may need updating for the timeframe update change. If not, just lmk.

@jjmccoy
Copy link
Member

jjmccoy commented Oct 16, 2024

@Nnaga1

FYI: So if the user goes to another page and comes back to the home page, the stats from that page temporarily bring those over to the home page and it refreshes. In this video example, it is Rules (for ingest) that has 34 currently. For this, I would suggest creating a ticket for the issue because it is outside the scope of your ticket but may need to be addressed so that users are not confused or think the information is misleading.

Action needed: Create new ticket

Screen.Recording.2024-10-16.at.12.14.05.PM.mov

@Nnaga1
Copy link
Contributor Author

Nnaga1 commented Oct 16, 2024

@Nnaga1

FYI: So if the user goes to another page and comes back to the home page, the stats from that page temporarily bring those over to the home page and it refreshes. In this video example, it is Rules (for ingest) that has 34 currently. For this, I would suggest creating a ticket for the issue because it is outside the scope of your ticket but may need to be addressed so that users are not confused or think the information is misleading.

Action needed: Create new ticket

Screen.Recording.2024-10-16.at.12.14.05.PM.mov

Dang I was unaware of that, thanks for lmk, I'll try to see if I can figure it out within this ticket, if not I'll create another, thanks 😄

@Nnaga1
Copy link
Contributor Author

Nnaga1 commented Oct 18, 2024

I did some additional testing on the issue you mentioned @jjmccoy, it seems like it does this not only for rules/executions for the overview only, if you go from home -> granules, the inverse will happen. It will show all 0's for the statuses before the actual counts. Same with if you go from a different page back to the home page, the granule errors will flash from being a list of what it was before to what it should be (i.e. it shows an old list for one second before changing to what it actually should show). It seems like in some cases/calls this behavior occurs. I think I will create a ticket detailing this, but I really dont think it is worth prioritizing at all probably, since it only lasts for a second and is somewhat persistent across the dashboard. I'm not going to consider that in the scope of this ticket. I think this ticket: #1153, should be reviewed before this is approved in order to clear the CI issues.

@jjmccoy
Copy link
Member

jjmccoy commented Oct 18, 2024

I did some additional testing on the issue you mentioned @jjmccoy, it seems like it does this not only for rules/executions for the overview only, if you go from home -> granules, the inverse will happen. It will show all 0's for the statuses before the actual counts. Same with if you go from a different page back to the home page, the granule errors will flash from being a list of what it was before to what it should be (i.e. it shows an old list for one second before changing to what it actually should show). It seems like in some cases/calls this behavior occurs. I think I will create a ticket detailing this, but I really dont think it is worth prioritizing at all probably, since it only lasts for a second and is somewhat persistent across the dashboard. I'm not going to consider that in the scope of this ticket. I think this ticket: #1153, should be reviewed before this is approved in order to clear the CI issues.

Yeah, I figured it was out of scope and a new ticket needs to be created for the issue.

@jjmccoy
Copy link
Member

jjmccoy commented Oct 18, 2024

@Nnaga1 This looks good. I believe there is a cypress test for the home page: main_page_spec.js. That may need updating for the timeframe update change. If not, just lmk.

I can approve it if this Cypress test doesn't need to be updated.

Copy link
Member

@jjmccoy jjmccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nnaga1 Thanks for testing it. LGTG!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants