Cumulus 3624 #1135
Cumulus 3624 #1135
Conversation
There was a problem hiding this comment.
- Can you add a cypress test to verify the functionality?
- The Modal says 'We will close this session in 5 minutes. ', but after 5 minutes, the Session is not closed or log me out, and the modal window is still there. I click 'Continue Session', the modal window closes and the session is still there.
| // Effect to handle showing the modal after 30 minutes of inactivity | ||
| useEffect(() => { | ||
| const checkInactivity = setInterval(() => { | ||
| if (Date.now() - lastKeyPress > 1800000 && !hasModal) { // 1800000 ms = 30 minutes |
There was a problem hiding this comment.
Can we make the inactivity time configurable?
There was a problem hiding this comment.
What's the difference between this inactivity timeout and session timeout? How do they work together?
The launchpad session can timeout regardless this inactivity, is it correct? Does the launchpad Session get refresh when we click 'Continue Session'?
There was a problem hiding this comment.
Can you add a cypress test to verify the functionality?
I don't think this is necessary as the other modals do not have tests written for this so it shouldn't be a requirement. If it is necessary I would be happy to do it but will need to be shown how as I normally do not deal with Cypress.
The Modal says 'We will close this session in 5 minutes. ', but after 5 minutes, the Session is not closed or log me out, and the modal window is still there. I click 'Continue Session', the modal window closes and the session is still there.
In progress
Can we make the inactivity time configurable?
Done
What's the difference between this inactivity timeout and session timeout? How do they work together?
The launchpad session can timeout regardless this inactivity, is it correct? Does the launchpad Session get refresh when we click 'Continue Session'?
Currently the session timeout just keeps track if the user is logged in or not. I am not sure what this timeout is set for. The inactivity modal will keep track of the users activity. If there is no activity after 30 min then a pop up will show and a second timer will start. This second timer is set for 5 min. If the user wishes to continue the session then they will need to interact with the modal and select "Continue session" otherwise the user will be logged out. In the future the session timeout and the inactivity timeout will be merged but this will be addressed in another ticket.
|
Additional comments:
|
Summary: Summary of changes
Addresses CUMULUS-3624: Active Session Timeouts - Inactivity Modal
Changes
PR Checklist