Sequencer improvements #95
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TimGroeneboom
commented
Apr 14, 2025
TimGroeneboom
commented
- improved thread safety while loading / saving sequences
- fixed issue where wrong output pins would get disconnected in AudioOutput of sequencer
- adapters get destroyed and re-created on new sequence load - fixed disconnecting of audio pins while their owning bufferplayers where already deleted
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
system_modules/napsequence/src/sequenceplayer.cpp:395
- The comparison directly on the atomic mTime without using load() may lead to incorrect behavior. Please load the current value of mTime into a local variable before performing comparisons.
if(mTime < 0.0)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.