Skip to content

Rendering improvements #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 42 commits into
base: 0.8
Choose a base branch
from
Open

Rendering improvements #90

wants to merge 42 commits into from

Conversation

lshoek
Copy link
Contributor

@lshoek lshoek commented Apr 6, 2025 •
edited
Loading

  • Select Vulkan 1.2 by default
  • Implement depth resolve attachments (MSAA) for depth render texture resources
  • Improved setup of nap::BoxFrameMesh
  • Introduce nap::ColorDepthRenderTarget to renderadvanced, restoring the simplicity of nap::RenderTarget
  • Remove Vulkan version check from renderadvanced
  • Remove nap::BufferBindingUVec4
  • Log SDL error when dummy window creation fails
  • Some refactoring in accordance with style guide
  • Fix: Uploading a DynamicWrite buffer (internally double-buffered) does not update the descriptor in the material instance

lshoek added 30 commits February 6, 2025 15:26
@lshoek
enable manual setup of box frame mesh
f7f767c
@lshoek
update additive blend mode to multiply alpha
de54cd6
@lshoek
update shader constants after material instance init
1af20eb
@lshoek
fix shader constant in material instance update
f2fd31a
@lshoek
enable vulkan multi draw indirect feature
9599d7d
@lshoek
Merge branch 'flexible_bindings' into deltax
6264c8d
@lshoek
Merge branch 'flexible_bindings' into deltax
baf94d9
@lshoek
Merge branch 'flexible_bindings' into deltax
ae5d125
@lshoek
implement multisample depth consume render passes
6ee6b41
@lshoek
Merge branch 'flexible_bindings' into msaadepth
8dd2c7e
@lshoek
favor designated initializers in renderutils and renderpass - refactor
ec95f5d
@lshoek
restore rendertarget color only - mv depthrendertarget to advanced - …
f8ffc6c 
…introduce colordepthrendertarget
@lshoek
add clear depth value - refactor initializers in snapshotrendertarget
dc57115
@lshoek
remove unused fill property
88bf932
@lshoek
Merge branch '0.8' into msaadepth
82c7a0a
@lshoek
restore render target attachments to 3
c248ba7
@lshoek
set depth render target clear values
fd3560e
@lshoek
favor empty over size check in flock demo
58d65a5
@lshoek
report sdl error if dummy window creation fails
c2b34f1
@lshoek
index boxframemesh more efficiently
aebe566
@lshoek
restore box frame mesh cull mode
fe465f8
@lshoek
fix material instance shader constant hashing
4790b2d
@lshoek
Merge branch '0.8' into msaadepth
0fbf6e2
@lshoek
Merge branch 'fix_constanthash' into msaadepth
6e13970
@lshoek
use fixed constant hashing in updateconstants function
7060f73
@lshoek
fix typo
d6d4415
@lshoek
Merge branch 'fix_constanthash' into msaadepth
51229ca
@lshoek
drop designated initializers for cpp17 compatibility
3aecce3
@lshoek
merge fix
23a4d61
@lshoek
remove vulkan version check on renderadvancedservice
45a8bd7
@lshoek lshoek requested a review from cklosters April 6, 2025 18:36
@cklosters
Copy link
Member

I assume you want to merge this into 0.8, instead of fix_constanthash, the build server doesn't monitor branches outside of main and 0.8

@lshoek lshoek changed the base branch from fix_constanthash to 0.8 April 11, 2025 12:37
@lshoek
Copy link
Contributor Author

lshoek commented Apr 11, 2025

True, I selected fix_constanthash as base to exlude its changes from the diff

@cklosters
Copy link
Member

Ah ok, well, let's review and merge fix_constanthash first then.

@cklosters cklosters added this to the 0.8 milestone Apr 11, 2025
@cklosters cklosters added rendering Render related Questions & Issues enhancement New feature or request labels Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cklosters cklosters Awaiting requested review from cklosters

Assignees
No one assigned
Labels
enhancement New feature or request rendering Render related Questions & Issues
Projects
None yet
Milestone
0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@lshoek @cklosters