Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make superclasses for the filter, smoother, and iterative smoother #33

Open
patnr opened this issue Feb 19, 2021 · 2 comments
Open

Make superclasses for the filter, smoother, and iterative smoother #33

patnr opened this issue Feb 19, 2021 · 2 comments
Labels
enhancement

Comments

@patnr
Copy link
Collaborator

patnr commented Feb 19, 2021

OOP and inheritance is a tantalizing prospect for organizing methods. Would it require big changes? Would it be worth it?
@yumengch
Copy link
Contributor

yumengch commented Mar 2, 2021

Is it related to issue #19 ?

@patnr
Copy link
Collaborator Author

patnr commented Mar 2, 2021

Well, I had this idea before #19 but I did learn from #19 about abstract classes.

However, this issue needs a lot of reflection. It might cause large changes, and I'm really not sure if it's worth it. I will classify it for v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patnr @yumengch