perf: dispose some TextEditingController manually

namidaco · Dec 13, 2023 · c0ed850 · c0ed850
1 parent cc8b3f0
commit c0ed850
Show file tree

Hide file tree

Showing 9 changed files with 32 additions and 1 deletion.
diff --git a/lib/ui/dialogs/edit_tags_dialog.dart b/lib/ui/dialogs/edit_tags_dialog.dart
@@ -54,6 +54,10 @@ Future<void> showSetYTLinkCommentDialog(List<Track> tracks, Color colorScheme) a
   final ytlink = singleTrack.youtubeLink;
   controller.text = ytlink;
   NamidaNavigator.inst.navigateDialog(
+    onDisposing: () {
+      controller.dispose();
+      ytSearchController.dispose();
+    },
     colorScheme: colorScheme,
     dialogBuilder: (theme) => Form(
       key: formKey,
@@ -246,6 +250,9 @@ Future<void> _editSingleTrackTagsDialog(Track track, Color colorScheme) async {
       canEditTags.close();
       didAutoExtractFromFilename.close();
       currentImagePath.close();
+      for (final c in tagsControllers.values) {
+        c.dispose();
+      }
     },
     scale: 0.94,
     colorScheme: colorScheme,

diff --git a/lib/ui/dialogs/general_popup_dialog.dart b/lib/ui/dialogs/general_popup_dialog.dart
@@ -144,6 +144,9 @@ Future<void> showGeneralPopupDialog(
     final title = isTags ? lang.SET_TAGS : lang.SET_MOODS;
     final subtitle = lang.SET_MOODS_SUBTITLE;
     await openDialog(
+      onDisposing: () {
+        controller.dispose();
+      },
       CustomBlurryDialog(
         title: title,
         actions: [
@@ -224,6 +227,9 @@ Future<void> showGeneralPopupDialog(
   void setTrackRating() async {
     final c = TextEditingController();
     await openDialog(
+      onDisposing: () {
+        c.dispose();
+      },
       CustomBlurryDialog(
         title: lang.SET_RATING,
         actions: [
@@ -255,6 +261,9 @@ Future<void> showGeneralPopupDialog(
     final controller = TextEditingController(text: playlistName);
     final GlobalKey<FormState> formKey = GlobalKey<FormState>();
     await openDialog(
+      onDisposing: () {
+        controller.dispose();
+      },
       Form(
         key: formKey,
         child: CustomBlurryDialog(
@@ -412,6 +421,7 @@ Future<void> showGeneralPopupDialog(
       onDisposing: () {
         filteredPaths.close();
         shouldCleanUp.close();
+        txtc.dispose();
       },
       CustomBlurryDialog(
         title: lang.CHOOSE,

diff --git a/lib/ui/dialogs/set_lrc_dialog.dart b/lib/ui/dialogs/set_lrc_dialog.dart
@@ -176,6 +176,7 @@ void showLRCSetDialog(Track track, Color colorScheme) async {
     await NamidaNavigator.inst.navigateDialog(
       onDisposing: () {
         newOffset.closeAfterDelay();
+        offsetController.dispose();
       },
       colorScheme: colorScheme,
       dialogBuilder: (theme) => CustomBlurryDialog(
@@ -311,6 +312,7 @@ void showLRCSetDialog(Track track, Color colorScheme) async {
       fetchedLyrics.close();
       selectedLyrics.close();
       expandedLyrics.close();
+      searchController.dispose();
     },
     colorScheme: colorScheme,
     dialogBuilder: (theme) => CustomBlurryDialog(

diff --git a/lib/ui/dialogs/setting_dialog_with_text_field.dart b/lib/ui/dialogs/setting_dialog_with_text_field.dart
@@ -52,6 +52,9 @@ Future<void> showSettingDialogWithTextField({
   void onTTSetChange() => onTrackTileSettingsChanged?.call();
 
   await NamidaNavigator.inst.navigateDialog(
+    onDisposing: () {
+      controller.dispose();
+    },
     dialog: Form(
       key: formKey,
       child: CustomBlurryDialog(

diff --git a/lib/ui/dialogs/track_advanced_dialog.dart b/lib/ui/dialogs/track_advanced_dialog.dart
@@ -476,6 +476,8 @@ void showLibraryTracksChooseDialog({
     onDisposing: () {
       allTracksList.close();
       selectedTrack.close();
+      searchController.dispose();
+      focusNode.dispose();
     },
     colorScheme: colorScheme,
     dialogBuilder: (theme) => CustomBlurryDialog(

diff --git a/lib/ui/widgets/settings/advanced_settings.dart b/lib/ui/widgets/settings/advanced_settings.dart
@@ -828,6 +828,8 @@ class UpdateDirectoryPathListTile extends StatelessWidget {
         NamidaNavigator.inst.navigateDialog(
             onDisposing: () {
               updateMissingOnly.close();
+              oldDirController.dispose();
+              newDirController.dispose();
             },
             colorScheme: colorScheme,
             dialogBuilder: (theme) => Form(

diff --git a/lib/ui/widgets/settings/indexer_settings.dart b/lib/ui/widgets/settings/indexer_settings.dart
@@ -676,6 +676,7 @@ class IndexerSettings extends SettingSubpageProvider {
     NamidaNavigator.inst.navigateDialog(
       onDisposing: () {
         updatingLibrary.close();
+        separatorsController.dispose();
       },
       onDismissing: isBlackListDialog
           ? null

diff --git a/lib/youtube/functions/add_to_playlist_sheet.dart b/lib/youtube/functions/add_to_playlist_sheet.dart
@@ -36,7 +36,7 @@ void showAddToPlaylistSheet({
 
   await Future.delayed(Duration.zero); // delay bcz sometimes doesnt show
   // ignore: use_build_context_synchronously
-  showModalBottomSheet(
+  await showModalBottomSheet(
     useRootNavigator: true,
     backgroundColor: Colors.transparent,
     context: context,
@@ -151,4 +151,5 @@ void showAddToPlaylistSheet({
       );
     },
   );
+  controller.disposeAfterAnimation();
 }
diff --git a/lib/youtube/functions/video_download_options.dart b/lib/youtube/functions/video_download_options.dart
@@ -215,6 +215,9 @@ Future<void> showVideoDownloadOptionsSheet({
       );
     },
   );
+  for (final c in controllersMap.values) {
+    c.dispose();
+  }
 }
 
 class YTDownloadOptionFolderListTile extends StatefulWidget {