perf: improve indexing speed by 38%~

this comes by dropping isolate, eliminating the need to serialize/deserialize data, reducing overhead & resulting in a more stable extraction
namidaco · Nov 17, 2023 · 6e445ed · 6e445ed
1 parent e6886da
commit 6e445ed
Show file tree

Hide file tree

Showing 4 changed files with 220 additions and 289 deletions.
diff --git a/lib/controller/edit_delete_controller.dart b/lib/controller/edit_delete_controller.dart
@@ -57,7 +57,7 @@ class EditDeleteController {
     final saveDir = await Directory(AppDirs.SAVED_ARTWORKS).create();
     final saveDirPath = saveDir.path;
     final newPath = "$saveDirPath${Platform.pathSeparator}${track.filenameWOExt}.png";
-    final imgFiles = await Indexer.inst.extractOneArtwork(
+    final imgFiles = await Indexer.inst.extractTracksArtworks(
       [track.path],
       albumIdendifiers: {track.path: track.albumIdentifier},
     );

diff --git a/lib/controller/ffmpeg_controller.dart b/lib/controller/ffmpeg_controller.dart
@@ -254,7 +254,7 @@ class NamidaFFMPEG {
           currentFailed++;
         } else {
           final file = await Indexer.inst
-              .extractOneArtwork(
+              .extractTracksArtworks(
                 [filee.path],
                 forceReExtract: true,
                 artworkPaths: {filee.path: cachedThumbnail.path},