Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: all async API; If you need sync, maybe futures::executor::block_on(future_fn) #230

Merged
merged 2 commits into from
May 19, 2024
Merged

Change: all async API; If you need sync, maybe futures::executor::block_on(future_fn) #230

merged 2 commits into from
May 19, 2024

Conversation

CherishCai
Copy link
Collaborator

relate #229

@CherishCai CherishCai added the enhancement New feature or request label May 17, 2024
@CherishCai CherishCai added this to the 0.4 milestone May 17, 2024
@CherishCai CherishCai requested a review from onewe May 17, 2024 11:36
@onewe
Copy link
Collaborator

onewe commented May 19, 2024

LGTM

@onewe onewe merged commit 9213793 into main May 19, 2024
5 checks passed
@CherishCai CherishCai deleted the change_all_async_api branch May 19, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onewe onewe onewe approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@CherishCai @onewe