chore: upgrade to iroh@v0.31.0 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For me this wasn't required to test. Doctor worked as expected regardless. It was purely the relay behavior that got stuck for me. |
|
totally! I just did the update to rule out that being part of the issue. |
2 tasks
matheus23
force-pushed
the
ramfox/iroh-main
branch
from
192c00c to
a017b19
Compare
matheus23
approved these changes
Jan 13, 2025
ramfox
force-pushed
the
ramfox/iroh-main
branch
from
1595922 to
6815bf8
Compare
ramfox
changed the title
ramfox
force-pushed
the
ramfox/iroh-main
branch
from
0126dd2 to
3aa1704
Compare
matheus23
added a commit
that referenced
this pull request
Jan 29, 2025
Depends on #15 (I need new iroh APIs.) ## Description <!-- A summary of what this pull request achieves and a rough list of changes. --> Shows a close reason when the connection closes. E.g: ``` Test finished after 1.238599231s: connection lost (reason: closed by peer: 0) ``` This error message indicates that it's an *intentional* closing of the connection. Otherwise it's something like: ``` Test finished after 1.238599231s: connection lost (reason: timed out) ``` This makes it easier to identify how the connection was lost. ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> Additionally, we ideally know if *we* closed the connection or if that was our peer. That info would be nice (but it's not as clear-cut, technically both could have closed the connection). Also - using different error codes might be nice, but `Endpoint::close` doesn't support that yet. I'd like to at least separate a close from Ctrl+C with a close from e.g. a panic/Err. ## Change checklist - [x] Self-review. - ~~[ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant.~~ - ~~[ ] Tests if relevant.~~ - [x] All breaking changes documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
upgrade iroh, portmapper, netcheck, etc dependencies
Change checklist