fs-store: ensure flush on drop

deny.toml

@@ -39,5 +39,4 @@ ignore = [
 [sources]
 allow-git = [
     "https://github.com/n0-computer/iroh-blobs.git",
-    "https://github.com/n0-computer/iroh-gossip.git",
 ]

src/store/fs.rs

@@ -14,6 +14,7 @@ use ed25519_dalek::{SignatureError, VerifyingKey};
 use iroh_blobs::Hash;
 use rand_core::CryptoRngCore;
 use redb::{Database, DatabaseError, ReadableMultimapTable, ReadableTable, ReadableTableMetadata};
+use tracing::warn;
 
 use super::{
     pubkeys::MemPublicKeyStore, DownloadPolicy, ImportNamespaceOutcome, OpenError, PublicKeyStore,
@@ -55,6 +56,14 @@ pub struct Store {
     pubkeys: MemPublicKeyStore,
 }
 
+impl Drop for Store {
+    fn drop(&mut self) {
+        if let Err(err) = self.flush() {
+            warn!("failed to trigger final flush: {:?}", err);
+        }
+    }
+}
+
 impl AsRef<Store> for Store {
     fn as_ref(&self) -> &Store {
         self
@@ -1121,7 +1130,6 @@ mod tests {
             .collect::<Result<Vec<_>>>()?;
 
         assert_eq!(expected, actual);
-        store.flush()?;
         Ok(())
     }
 
@@ -1138,7 +1146,6 @@ mod tests {
         }
 
         // TODO: write test checking that the indexing is done correctly
-        store.flush()?;
         Ok(())
     }
 }