Skip to content

Commit

Permalink
Merge pull request dana-team#199 from dvirgilad/fix/chart-name
Browse files Browse the repository at this point in the history
fix: rename helm chart to fix release workflow
  • Loading branch information
mzeevi authored Aug 20, 2024
2 parents 7d5ecc2 + c0e6d46 commit 2a98ed0
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
1 change: 1 addition & 0 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ jobs:
run: |
helm package charts/${{ steps.chart-name.outputs.value }} --version ${{ steps.version.outputs.value }} --app-version ${{ steps.version.outputs.value }}
echo "package=${{ steps.chart-name.outputs.value }}-${{ steps.version.outputs.value }}.tgz" >> "$GITHUB_OUTPUT"
- name: Upload chart as artifact
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32
with:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ $ make prereq PROVIDER_DNS_REALM=<value> PROVIDER_DNS_KDC=<value> PROVIDER_DNS_P
Use `Helm` to deploy `Capp` with all the needed resources. Only deploy it after installing the [prereq](#prerequisites).

```bash
$ helm upgrade --install capp-operatoor --namespace capp-operator-system --create-namespace oci://ghcr.io/dana-team/helm-charts/container-app-operator --version <release>
$ helm upgrade --install capp-operator --namespace capp-operator-system --create-namespace oci://ghcr.io/dana-team/helm-charts/container-app-operator --version <release>
```

#### Deploy with Makefile
Expand Down
2 changes: 1 addition & 1 deletion charts/container-app-operator/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v2
name: capp-operator
name: container-app-operator
description: A Helm chart for container-app-operator

# A chart can be either an 'application' or a 'library' chart.
Expand Down
2 changes: 0 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ github.com/crossplane/crossplane-runtime v1.16.0 h1:lz+l0wEB3qowdTmN7t0PZkfuNSvf
github.com/crossplane/crossplane-runtime v1.16.0/go.mod h1:Pz2tdGVMF6KDGzHZOkvKro0nKc8EzK0sb/nSA7pH4Dc=
github.com/crossplane/upjet v1.3.0 h1:qRgcfqLz4M2v7enUku3xEriY5poc5XVbRl98nbvvu+E=
github.com/crossplane/upjet v1.3.0/go.mod h1:3pDVtCgyBc5f2Zx4K5HEPxxhjndmOc5CHCJNpIivK/g=
github.com/dana-team/cert-external-issuer v0.0.0-20240812103756-3404b13d86da h1:DX1Qdv1bxgyk+HGSR3ssZVDww5bLvQNEQTdWgjYjLSQ=
github.com/dana-team/cert-external-issuer v0.0.0-20240812103756-3404b13d86da/go.mod h1:LYZ8pCQZFmfot0+SwIh1OxyGZelMZjKuJM1W5JUxBIY=
github.com/dana-team/cert-external-issuer v0.1.0 h1:ObSY+ioxhEqwsLVnfqNznpHKH0CDJbYL8UcGVT44MuM=
github.com/dana-team/cert-external-issuer v0.1.0/go.mod h1:LYZ8pCQZFmfot0+SwIh1OxyGZelMZjKuJM1W5JUxBIY=
github.com/dana-team/nfspvc-operator v0.3.0 h1:K8++dWanaDGLxm5kqLUG6fqeaW/nLR+hrSr04MKC2d0=
Expand Down

0 comments on commit 2a98ed0

Please sign in to comment.