-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home page box #1809
Home page box #1809
Conversation
ee801d1
to
4165571
Compare
I think this is hitting the point where it needs a designer to have a think - @lucascumsille ? |
TODOS:
|
@ajparsons I have included the new layout for the "Quick links" sections. Here is a video of how it would look on mobile and desktop: Screen.Recording.2024-08-19.at.08.59.04.movI notched down the size and fonts of cards so they don't look so prominent, but they are still noticeable. Apologies for the amount of commits, I would normally rebase, but trying to run
I think is the same problem we had in the past, let me know if you know how to fix it, and I'll rebase =) Regarding the images for the other parliaments, due to timing, I didn't have much time to keep looking, but during the week I might have some extra time. In the meantime let me know what you think of the current layout and if you need me to make some changes. |
07bafe6
to
5e37c1d
Compare
Ok, I've rebased that and fixed the tests. On images: if you could give me an example of how you'd make the UK image responsive - I can apply that to the others. I'm a bit stuck on the images and putting it down for the day. NI Assembly is fine - it's a nice horizontal building that bits behind the banner. The trouble with the other two: Scottish Parliament: to get clean sky behind it, you're usually looking at quite a busy bit of the building architecturally - which makes it hard to layer the search box on top of it. Like this is fine: But is less nice than the others. Don't have to get it right first time. Senedd I've tried a few, but the current one is the best. Again a problem where the architecturally distinctive bit is hard to layer a box onto of. |
@ajparsons I added the CSS rules + Images for the UK Parliament. A few considerations:
I have added a rule for Let me know what you think |
Ok, I this now does everything I think is needed - thanks for the work on those devolved parliament images Lucas. @dracos : Is there anything in this you want to look at in more detail? Lucas was a bit concerned that the devolved parliament images were a bit heavy even compressed. They're off the main homepage so I think that's more ok, but flagging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of tiny questions.
On the images - firstly, we need to take out the photos we're not using that are stock? And secondly, running e.g. the Scottish huge one through squoosh.app gets it from 85.2KB to 40.4KB kept as a webp or 59.4KB JPEG, so would like them to at least go through that. Or Senedd huge goes from 274KB to 147 or 135KB.
d86c1d8
to
4d6dbc5
Compare
Also, just one thought - check the background colour is okay if the images don't load, I see WEBP is pretty well supported nowadays but just to be nice to anyone that doesn't get it. |
Ok, I need to merge that last set of fixups - but I've:
If ok with the different ways the Senedd and SP handle data - that should be that round of fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good - only thing is why is parliament-photo.jpg in there, it doesn't appear to be used, but there may be a reason for that
a5d440f
to
e66359f
Compare
- Search box expanded into generic title box - Merriweather for new style title - SearchBox class controls config for different parliaments - Temp images for different parliament backgrounds.
- Updated -color - Updated to use same colour as WDTK - Updated logo - Added lighter version of primary color - Improved focus status for buttons - Decreased button padding
- Top bar crowded
e66359f
to
7c14b4e
Compare
Related to #1789 and #1791
This is a go at reducing some of the elements on the home page - as the search box now accepts postcodes, we can combine the two search boxes together. This PR:
If we're broadly good with this approach, need to:
Known issues: