-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Project Healthcare README and Documentation with Key Updates #97
base: main
Are you sure you want to change the base?
Conversation
…ion and sequence diagram
Reviewer's Guide by SourceryThis PR significantly enhances the project documentation by restructuring the README.md file and adding comprehensive documentation. The changes focus on improving user experience through better organization, detailed installation instructions, and the addition of visual aids like sequence diagrams to explain system workflows. Sequence diagram for Project Healthcare system workflowsequenceDiagram
participant PatientApp
participant DiagnosisAPI
participant GeolocationAPI
participant QueueSystem
participant FacilityDatabase
PatientApp->>DiagnosisAPI: Send symptoms
DiagnosisAPI->>QueueSystem: Store request
QueueSystem->>FacilityDatabase: Fetch facility data
FacilityDatabase-->>QueueSystem: Return facility data
QueueSystem-->>DiagnosisAPI: Return diagnosis results
DiagnosisAPI-->>PatientApp: Send diagnosis results
PatientApp->>GeolocationAPI: Request location-based facilities
GeolocationAPI->>FacilityDatabase: Query nearby facilities
FacilityDatabase-->>GeolocationAPI: Return nearby facilities
GeolocationAPI-->>PatientApp: Send facility suggestions
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Khan-Ramsha - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider moving the documentation from Google Docs into the repository's /docs folder to maintain version control and ensure offline accessibility
- The sequence diagram image is referenced from a personal fork. Please move the image to the main repository and update the reference accordingly
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Quality Gate passedIssues Measures |
Hey, I have moved the image to the main repo and updated the documentation to redirect to the repo's /doc folder. Kindly review and let me know if there's anything else you'd like me to adjust. Thankyou! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Khan-Ramsha Had you submitted your candidature as asked here?
#8 (comment)
Additionally,
- the readme is fine for now but the docs have to be moved to project root. all docs should be separate from apps source code.
- This issue for which you have raised the PR needs to be consulted with C4GT team. They will be involved in vetting suitable advisors first. In the meantime you can amend the changes requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try raising the readme and docs as 2 seperate PRs. They do not necessarily have to be tagged with C4GT.
Yes, I've submitted. |
I've raised two separate PRs for the README and docs. Kindly review them at your convenience. |
PR for #8
Updated README file: Restructured the readme for better clarity and user experience, Added new sections: Getting Started, Learn the Basics, Contribute, and Supported By, Included installation steps for Linux, Mac, and Windows users with detailed guidance on using WSL for Windows, Integrated sequence diagram to explain the system workflow.
Added Documentation: Developed detailed product documentation, including system architecture, hardware/software requirements, and API details (Diagnosis API and Geolocation API).
Fixing Links: Resolved the issue where the "Documentation" button did not redirect to any content by linking it to the new detailed documentation.
Kindly review the changes and let me know if there's anything that needs to be adjusted or improved, I'll address them right away.
Summary by Sourcery
Enhance the README and documentation by restructuring for clarity, adding installation steps, and integrating a sequence diagram. Develop comprehensive product documentation and fix the documentation link issue.
Bug Fixes:
Documentation: