Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sqlite repo #56

Merged
merged 14 commits into from
Sep 2, 2024
Merged

Feature/sqlite repo #56

merged 14 commits into from
Sep 2, 2024

Conversation

codecakes
Copy link
Contributor

Implements database configuration for sqlite repo in issue #26 by:

  • Implementing configure_database_session(services, settings) and on_start
  • Adding support libraries to pyproject.toml

@codecakes codecakes added the enhancement New feature or request label Sep 2, 2024
@codecakes codecakes added this to the v1 milestone Sep 2, 2024
@codecakes codecakes self-assigned this Sep 2, 2024
@codecakes codecakes marked this pull request as ready for review September 2, 2024 20:50
Copy link
Contributor

sourcery-ai bot commented Sep 2, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link
Contributor Author

@codecakes codecakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sourcery-ai review

@codecakes codecakes enabled auto-merge September 2, 2024 20:57
@codecakes codecakes disabled auto-merge September 2, 2024 20:58
@codecakes codecakes merged commit e8fb0a6 into main Sep 2, 2024
9 checks passed
@codecakes codecakes deleted the feature/sqlite-repo branch September 2, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant