[C4GT Community]: Replace FromOriginMatchHeader secret to locally set environment variable

[codecakes]

Ticket Contents

Description

There is a binder FromHeader here:

https://github.com/Xcov19/project-healthcare/blob/e8fb0a6a8a6cbcb0f7fd1b8f7429790eadea2930/xcov19/app/settings.py#L48

and here:
https://github.com/Xcov19/project-healthcare/blob/e8fb0a6a8a6cbcb0f7fd1b8f7429790eadea2930/xcov19/app/middleware.py#L20

which are currently hardcoded. It needs to be replaced with a value sourced directly from environment variable. The value can be any sophisticated super secret string one can conjure in the localhost.

The code describes where and why this is used.

Reference: You see this getting used during API calls here: https://project-healthcare.onrender.com/docs

Goals

Goals

• Refactor to use locally generated from environment variable
• make run and smoke test to verify APIs don't break after refactor

Expected Outcome

• No change in API behaviour
• Sending wrong secret in the API call which is different from locally generated secret fails

Acceptance Criteria

There is a Pytest e2e Testsuite which tests for the expected outcomes in the following cases:

• Test asserts true when no change in API behaviour when correct secret is supplied
• Test asserts failure when sending wrong secret in the API call which is different from locally generated secret fails
• No mocks are used.

See https://tonybaloney.github.io/posts/async-test-patterns-for-pytest-and-unittest.html

Implementation Details

1. Ensure locally sourced env var is set in `settings.py``
2. It is then set in https://github.com/Xcov19/project-healthcare/blob/e8fb0a6a8a6cbcb0f7fd1b8f7429790eadea2930/xcov19/app/settings.py#L48
3. The placeholder string is replaced in relevant places with locally set env variable

Mockups/Wireframes

No response

Product Name

project-healthcare

Organisation Name

XCoV19

Domain

Healthcare

Tech Skills Needed

CI/CD, Debugging, Python, RESTful APIs, Swagger, Test, Testing Library

Mentor(s)

@codecakes

Complexity

Medium

Category

API, Backend, Beginner Friendly, CI/CD, Testing

[TheSciPro]

Hey,
Is this issue still open?

[codecakes]

Hey, Is this issue still open?

@TheSciPro
Yes. you can check all issues by their status

[MustafaAkolawala]

Hello,
can I get this issue assigned to me

[prajwal2431]

assign this issue to me

[codecakes]

@prajwal2431 @TheSciPro @MustafaAkolawala if you follow the necessary actions asked in this issue, you are free to raise a PR. It is a on a first-come first-serve basis. Some general pointers to follow when implementing PR for this issue are given here: #109