build: various mux and upstream version bumps. Improve semver matcher… #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to be more consistent with elements.
|
@cjpillsbury is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cjpillsbury
commented
Jul 26, 2024
| "@types/probe-image-size": "^7.0.0", | ||
| "copy-to-clipboard": "^3.3.1", | ||
| "got": "^11.8.3", | ||
| "hls.js": "^1.4.14", | ||
| "hls.js": "~1.5.11", |
There was a problem hiding this comment.
consistent with playback-core specification
cjpillsbury
commented
Jul 26, 2024
| "micro": "9.3.5-canary.3", | ||
| "mux-embed": "^4.30.0", | ||
| "mux-embed": "~5.2.0", |
There was a problem hiding this comment.
consistent with playback-core specification
cjpillsbury
commented
Jul 26, 2024
| @@ -33,8 +33,8 @@ const PlyrPlayer: React.FC<Props> = ({ playbackId, poster, currentTime, onLoaded | |||
| useEffect(() => { | |||
| const video = videoRef.current; | |||
| const src = `${getStreamBaseUrl()}/${playbackId}.m3u8`; | |||
| let hls: Hls | null; | |||
| hls = null; | |||
| let hls: Hls | undefined; | |||
There was a problem hiding this comment.
now that we have official types in mux embed, this should be undefined
luwes
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s to be more consistent with elements.