Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MidiFileToEvent doesn't work for midi files without note_off #4

Open
levinericzimmermann opened this issue Dec 4, 2022 · 0 comments
Open

MidiFileToEvent doesn't work for midi files without note_off #4

levinericzimmermann opened this issue Dec 4, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@levinericzimmermann
Copy link
Member

Some midi exporter don't use note_off messages, but note_on messages with velocity=0. Mutwo currently can't pass such midi files. This should be fixed by adding a new flag to EventToMidiFile.

Thanks @timpauli for detecting this bug.
@levinericzimmermann levinericzimmermann added the bug Something isn't working label Dec 4, 2022
levinericzimmermann added a commit that referenced this issue Jul 23, 2023
@levinericzimmermann
converters/backends: Raise warning if no note_off msg could be found
fc08e3a 
This is an unexpected behaviour and most likely point to the bug which
is described in #4.
This patch doesn't fix the issue, but at least the user is informed
now what the problem is.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@levinericzimmermann