sovereign chain simulator updates #6773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusmihaic
reviewed
Feb 4, 2025
| @@ -76,6 +79,112 @@ func TestChainSimulator_GenerateBlocksShouldWork(t *testing.T) { | |||
| require.Nil(t, err) | |||
| } | |||
|
|
|||
| func TestSovereignChainSimulator_GenerateBlocksAndEpochChangeShouldWork(t *testing.T) { | |||
There was a problem hiding this comment.
These tests are duplicated from:
1.TestChainSimulator_GenerateBlocksAndEpochChangeShouldWork
2. TestSimulator_TriggerChangeOfEpoch
Also, I think we can delete that time.Sleep if it works regardless
There was a problem hiding this comment.
Could add a common test functoinality with chainSimulator interface in which you pass which node(shardID) to use
cmd/sovereignnode/chainSimulator/sovereignChainSimulator_test.go
Outdated
Show resolved
Hide resolved
mariusmihaic
requested changes
Feb 5, 2025
| @@ -18,6 +18,17 @@ import ( | |||
| "github.com/stretchr/testify/require" | |||
| ) | |||
|
|
|||
| // TriggerChangeOfEpoch - | |||
| func TriggerChangeOfEpoch(t *testing.T, chainSimulator ChainSimulator, nodeHandler chainSimulatorProcess.NodeHandler) { | |||
There was a problem hiding this comment.
This func can definelty fail if called from any other epoch than 0.
We can do it better and iterate from i:= currentEpoch; i< currentEpoch+4
mariusmihaic
approved these changes
Feb 5, 2025
miiu96
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?