tests: commands: only use one subtest #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ELL 0.72 recently changed the way the subtests are executed: each one is now executed in a dedicated process, forked from the same parent [1]. This is causing issues for the 'commands' test, because some shared info are shared between subtests. 'info' could be created in a shared memory with mmap(), but it looks like there are more changes needed in mptcpd itself to cope with that, probably the memory allocated for the pm structure and more. Then, for the moment, it looks better and easier to simplify things, an only use one subtest. Link: https://git.kernel.org/pub/scm/libs/ell/ell.git/commit/?id=e0628c4 [1] Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
|
@ossama-othman I suggest merging, not to affect future development, and daily errors sent by the CI. I hope that's OK! Do not hesitate to tell me if there is anything to change, I can easily create another PR fixing this |
Pull Request Test Coverage Report for Build 13270086376Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ELL 0.72 recently changed the way the subtests are executed: each one is now executed in a dedicated process, forked from the same parent [1].
This is causing issues for the
commandstest, because some shared info are shared between subtests.infocould be created in a shared memory withmmap(), but it looks like there are more changes needed in mptcpd itself to cope with that, probably the memory allocated for the pm structure and more.Then, for the moment, it looks better and easier to simplify things, an only use one subtest.
While at it, also fix
l_test_init()used with the wrongargv(the one for mptcpd, instead of the one for the test).Note that the breaking issue has been reported to the ELL ML [2], but this didn't block the 0.72 release :) (cc @mjmartineau)
Link: https://git.kernel.org/pub/scm/libs/ell/ell.git/commit/?id=e0628c4 [1]
Link: https://lore.kernel.org/ell/17dba9d9-6fce-41a6-a136-e47179c6a206@kernel.org/T/ [2]