Skip to content

Commit

Permalink
Run re2 ABI tests against Ubuntu 22.04
Browse files Browse the repository at this point in the history
To match the ubuntu-latest GitHub runner, upgrade the re2 ABI tests to
run against Ubuntu 22.04 using the newly compiled libre2-dev packages
from https://github.com/mudge/re2-ci/releases/tag/v22.04

As Ubuntu 22.04 has libabsl-dev available, there's no need to manually
install it and we switch to using apt -f install so it'll install the
dependency automatically.
  • Loading branch information
mudge committed Jul 16, 2024
1 parent b02e7a3 commit faf6b0f
Showing 1 changed file with 4 additions and 12 deletions.
16 changes: 4 additions & 12 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:

test-re2-abi:
needs: "build-cruby-gem"
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
strategy:
matrix:
ruby: ["3.3", "2.6"] # oldest and newest
Expand All @@ -101,22 +101,14 @@ jobs:
soname: 10
- version: "20230701"
soname: 11
needs_abseil: true
steps:
- uses: actions/checkout@v4
- name: Remove any existing libre2 installation
run: sudo apt-get remove -y libre2-dev libre2-5
- name: Install Abseil for newer re2 releases
if: ${{ matrix.libre2.needs_abseil }}
run: |
sudo apt-get install -y software-properties-common
sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys E996735927E427A733BB653E374C7797FB006459
sudo add-apt-repository "deb https://ppa.launchpadcontent.net/savoury1/build-tools/ubuntu focal main"
sudo apt-get install -y libabsl-dev
run: sudo apt-get remove -y libre2-dev libre2-9
- name: Download and install specific release of libre2
run: |
curl -Lo libre2-dev.deb https://github.com/mudge/re2-ci/releases/download/v2/libre2-dev_${{ matrix.libre2.version }}_amd64.deb
sudo dpkg -i libre2-dev.deb
curl -Lo libre2-dev.deb https://github.com/mudge/re2-ci/releases/download/v22.04/libre2-dev_${{ matrix.libre2.version }}_amd64.deb
sudo apt -f install ./libre2-dev.deb
- uses: ruby/setup-ruby@v1
with:
ruby-version: "${{ matrix.ruby }}"
Expand Down

0 comments on commit faf6b0f

Please sign in to comment.