Skip to content

Commit

Permalink
Upgrade artifact-related GitHub Actions
Browse files Browse the repository at this point in the history
Previously, I downgraded from the new v4 of upload-artifact and
download-artifact after seeing flakey tests but as Nokogiri has upgraded
(see
sparklemotion/nokogiri@78c48b1),
let's give it another go too.
  • Loading branch information
mudge committed Apr 1, 2024
1 parent 5013f63 commit c7fc5c7
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 15 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
ruby-version: "3.2"
- run: gem install --no-document yard redcarpet
- run: yardoc
- uses: actions/upload-pages-artifact@v2
- uses: actions/upload-pages-artifact@v3
with:
path: "doc/"

Expand All @@ -32,4 +32,4 @@ jobs:
steps:
- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v3
uses: actions/deploy-pages@v4
26 changes: 13 additions & 13 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
ruby-version: "3.2"
bundler-cache: true
- run: ./scripts/test-gem-build gems ruby ${{github.ref_type}}
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: cruby-gem
path: gems
Expand Down Expand Up @@ -60,7 +60,7 @@ jobs:
docker run --rm -v "$(pwd):/re2" -w /re2 \
"ghcr.io/rake-compiler/rake-compiler-dock-image:1.4.0-mri-${{matrix.platform}}" \
./scripts/test-gem-build gems ${{matrix.platform}} ${{github.ref_type}}
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: "cruby-${{matrix.platform}}-gem"
path: gems
Expand Down Expand Up @@ -114,7 +114,7 @@ jobs:
with:
ruby-version: "${{ matrix.ruby }}"
bundler-cache: true
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: cruby-gem
path: gems
Expand Down Expand Up @@ -153,7 +153,7 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{matrix.ruby}}
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: cruby-gem
path: gems
Expand Down Expand Up @@ -184,7 +184,7 @@ jobs:
with:
ruby-version: "3.2"
bundler-cache: true
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: cruby-gem
path: gems
Expand All @@ -202,7 +202,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: cruby-aarch64-linux-gem
path: gems
Expand All @@ -224,7 +224,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: cruby-arm-linux-gem
path: gems
Expand All @@ -249,7 +249,7 @@ jobs:
- uses: MSP-Greg/setup-ruby-pkgs@v1
with:
ruby-version: "${{matrix.ruby}}"
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: cruby-x64-mingw-ucrt-gem
path: gems
Expand All @@ -269,7 +269,7 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
ruby-version: "${{matrix.ruby}}"
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: cruby-x64-mingw32-gem
path: gems
Expand All @@ -286,7 +286,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: cruby-x86-linux-gem
path: gems
Expand All @@ -311,7 +311,7 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
ruby-version: "${{matrix.ruby}}"
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: cruby-x86_64-linux-gem
path: gems
Expand All @@ -330,7 +330,7 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
ruby-version: "${{matrix.ruby}}"
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: cruby-x86_64-darwin-gem
path: gems
Expand All @@ -348,7 +348,7 @@ jobs:
image: "ruby:${{matrix.ruby}}-alpine"
steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: cruby-x86_64-linux-gem
path: gems
Expand Down

0 comments on commit c7fc5c7

Please sign in to comment.