Skip to content

Commit

Permalink
Precompile native gems for Ruby 3.3.0-preview3
Browse files Browse the repository at this point in the history
Use [rake-compiler-dock
1.4.0.rc1](https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0.rc1)
to precompile a native gem for Ruby 3.3 and test it on all supported
platforms.

This won't be safe to release until Ruby 3.3's ABI is guaranteed not to
change (the recently released 3.3.0-rc1 shows the first sign of ABI
stability but that isn't supported by rake-compiler-dock yet).
  • Loading branch information
mudge committed Dec 12, 2023
1 parent 60d58aa commit 1781563
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 10 deletions.
16 changes: 9 additions & 7 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,8 @@ jobs:
runs-on: "windows-2022"
- ruby: "3.2"
runs-on: "windows-2022"
- ruby: "3.3"
runs-on: "windows-2022"
runs-on: ${{matrix.runs-on}}
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -176,7 +178,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ["2.6", "2.7", "3.0", "3.1", "3.2"]
ruby: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3"]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -198,7 +200,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ["2.6", "2.7", "3.0", "3.1", "3.2"]
ruby: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3"]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -220,7 +222,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ["3.1", "3.2"]
ruby: ["3.1", "3.2", "3.3"]
runs-on: windows-2022
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -260,7 +262,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ["2.6", "2.7", "3.0", "3.1", "3.2"]
ruby: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3"]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -282,7 +284,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ["2.6", "2.7", "3.0", "3.1", "3.2"]
ruby: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3"]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -301,7 +303,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ["2.6", "2.7", "3.0", "3.1", "3.2"]
ruby: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3"]
runs-on: macos-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -320,7 +322,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ["2.6", "2.7", "3.0", "3.1", "3.2"]
ruby: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3"]
runs-on: ubuntu-latest
container:
image: "ruby:${{matrix.ruby}}-alpine"
Expand Down
2 changes: 1 addition & 1 deletion Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Gem::PackageTask.new(RE2_GEM_SPEC) do |p|
p.need_tar = false
end

CROSS_RUBY_VERSIONS = %w[3.2.0 3.1.0 3.0.0 2.7.0 2.6.0].join(':')
CROSS_RUBY_VERSIONS = %w[3.3.0 3.2.0 3.1.0 3.0.0 2.7.0 2.6.0].join(':')
CROSS_RUBY_PLATFORMS = %w[
aarch64-linux
arm-linux
Expand Down
4 changes: 2 additions & 2 deletions re2.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ Gem::Specification.new do |s|
"spec/re2/set_spec.rb",
"spec/re2/scanner_spec.rb"
]
s.add_development_dependency("rake-compiler", "~> 1.2.1")
s.add_development_dependency("rake-compiler-dock", "~> 1.3.0")
s.add_development_dependency("rake-compiler", "~> 1.2.5")
s.add_development_dependency("rake-compiler-dock", "~> 1.4.0.rc1")
s.add_development_dependency("rspec", "~> 3.2")
s.add_runtime_dependency("mini_portile2", "~> 2.8.5") # keep version in sync with extconf.rb
end

0 comments on commit 1781563

Please sign in to comment.