Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idea to remove swizzling #1

Open
malhal opened this issue Sep 1, 2022 · 1 comment
Open

Idea to remove swizzling #1

malhal opened this issue Sep 1, 2022 · 1 comment

Comments

@malhal
Copy link

malhal commented Sep 1, 2022 •
edited
Loading

Just thought I'd share an idea that if you used UIViewControllerRepresentable instead of UIViewRepresentable you could handle disappearing without having to swizzle and you wouldn't need to search for nearest VC either. Similar to MyViewController in this code I posted to Stackoverflow, before I found your library (which I found via this blog btw)

I think Apple call theirs PresentationHostingController.
@mtzaquia
Copy link
Owner

Hey @malhal! Thank you for the tip.

I haven't been able to support this as much as I would like - there are some missing features I would love to get done here...

Meanwhile, if you ever get this implementation done without swizzling, I would be super happy to look into your PR and merge this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@malhal @mtzaquia