-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python-sqlmodel: New package #17403
python-sqlmodel: New package #17403
Conversation
mingw-w64-python-sqlmodel/PKGBUILD
Outdated
_realname=sqlmodel | ||
pkgbase=mingw-w64-python-${_realname} | ||
pkgname=("${MINGW_PACKAGE_PREFIX}-python-${_realname}") | ||
pkgver=0.0.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should pkgver be generated from git commit using pkgver function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary. I hope this PR will be merged and we will soon see a new version with official sqlalchemy 2.0
support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make this PR a draft. I just want to draw attention to the need to add sqlalchemy 2.0
support for this package in a modern distribution. We already have an FastAPI, but no integration with database.
37ad98e
to
5620d55
Compare
5620d55
to
e725e27
Compare
This also has a broken version: |
I've created an upstream question (fastapi/sqlmodel#701) since bug reports aren't wanted by the maintainer. |
I guess in this case we have to patch the pyproject.toml |
Done, please review again. |
Based on fastapi/sqlmodel#563.UPDATE: Good news. Porting to
SQLAlchemi 2.0
done there fastapi/sqlmodel#700.