Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-sqlmodel: New package #17403

Merged
merged 2 commits into from
Nov 19, 2023
Merged

Conversation

podsvirov
Copy link
Collaborator

@podsvirov podsvirov commented Jun 1, 2023

Based on fastapi/sqlmodel#563.

UPDATE: Good news. Porting to SQLAlchemi 2.0 done there fastapi/sqlmodel#700.

_realname=sqlmodel
pkgbase=mingw-w64-python-${_realname}
pkgname=("${MINGW_PACKAGE_PREFIX}-python-${_realname}")
pkgver=0.0.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should pkgver be generated from git commit using pkgver function?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary. I hope this PR will be merged and we will soon see a new version with official sqlalchemy 2.0 support.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make this PR a draft. I just want to draw attention to the need to add sqlalchemy 2.0 support for this package in a modern distribution. We already have an FastAPI, but no integration with database.

@podsvirov podsvirov marked this pull request as draft June 11, 2023 15:01
@podsvirov podsvirov force-pushed the python-sqlmodel-new-package branch from 37ad98e to 5620d55 Compare October 4, 2023 17:25
@podsvirov podsvirov force-pushed the python-sqlmodel-new-package branch from 5620d55 to e725e27 Compare November 18, 2023 13:13
@podsvirov podsvirov marked this pull request as ready for review November 18, 2023 13:29
@podsvirov
Copy link
Collaborator Author

Cc: @lazka, @Biswa96

@podsvirov podsvirov requested a review from Biswa96 November 18, 2023 13:36
@lazka
Copy link
Member

lazka commented Nov 18, 2023

This also has a broken version: Version: 0

@lazka
Copy link
Member

lazka commented Nov 18, 2023

I've created an upstream question (fastapi/sqlmodel#701) since bug reports aren't wanted by the maintainer.

@lazka
Copy link
Member

lazka commented Nov 18, 2023

I guess in this case we have to patch the pyproject.toml

@podsvirov
Copy link
Collaborator Author

I guess in this case we have to patch the pyproject.toml

Done, please review again.

@lazka lazka merged commit faedc35 into msys2:master Nov 19, 2023
7 checks passed
@podsvirov podsvirov deleted the python-sqlmodel-new-package branch November 19, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants