Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Nitro Views!!!!!!!!! 🥳 #512

Merged
merged 37 commits into from
Feb 19, 2025
Merged

feat: Nitro Views!!!!!!!!! 🥳 #512

merged 37 commits into from
Feb 19, 2025

Conversation

mrousavy
Copy link
Owner

@mrousavy mrousavy commented Jan 23, 2025

What

Screen.Recording.2025-01-23.at.14.41.12.mov
  • Updates example to react-native 0.78.0-rc.1
  • (RN Screens and RN Safe Area need local patches as they break on RN 78 for now)
  • Updates the Hybrid View to blue light effect
  • Add example for views

Changes

  • Fixes Nitro Views to properly produce code that compiles on Fabric 0.78
  • Fixes boolean getters that start with is not properly compiling (the Swift/Kotlin compiler changes the name for those props, isBlue -> isBlue() vs getIsBlue())

Blockers

  • react-native-safe-area-context breaks on RN 0.78-rc.0 (fixed in a recent beta)
  • react-native-screens breaks on RN 0.78-rc.0 (waiting for beta)

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nitro-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 7:49pm

@mrousavy mrousavy changed the title feat: Upgrade to react-native 0.78 feat: Nitro Views!!!!!!!!! Jan 23, 2025
@mrousavy mrousavy changed the title feat: Nitro Views!!!!!!!!! feat: Nitro Views!!!!!!!!! 🥳 Jan 23, 2025
@mrousavy
Copy link
Owner Author

Android works as well! 🥳

Screen.Recording.2025-01-23.at.17.43.09.mov

@kkafar
Copy link

kkafar commented Feb 19, 2025

@mrousavy I've released screens 4.9.0-beta.0 with 0.78 support. FYI: It's in beta because it supports only 0.78 and I plan to restore backward compat before relasing stable.

@mrousavy
Copy link
Owner Author

Thanks so much @kkafar - Nitro Views builds now!! I'll merge this and release it shortly :)

@mrousavy mrousavy merged commit 28f9c4a into main Feb 19, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants