improve unit tests

mrjsj · Dec 22, 2024 · d5bc86e · d5bc86e
1 parent e335ed4
commit d5bc86e
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 12 deletions.
diff --git a/tests/internal/fabric_api/test_lakehouse.py b/tests/internal/fabric_api/test_lakehouse.py
@@ -16,32 +16,56 @@ def test_get_workspace_lakehouses():
     assert isinstance(lakehouses, list)
     assert len(lakehouses) > 0
 
+    lakehouse = [lakehouse for lakehouse in lakehouses if lakehouse["id"] == LAKEHOUSE_ID]
+
+    assert len(lakehouse) == 1
+    assert isinstance(lakehouse[0], dict)
+    assert lakehouse[0]["displayName"] == LAKEHOUSE_NAME
+    assert lakehouse[0]["id"] == LAKEHOUSE_ID
+
 def test_get_workspace_lakehouses_by_id():
     lakehouses = get_workspace_lakehouses(workspace_id=WORKSPACE_ID)
     assert isinstance(lakehouses, list)
     assert len(lakehouses) > 0
 
+    lakehouse = [lakehouse for lakehouse in lakehouses if lakehouse["id"] == LAKEHOUSE_ID]
+
+    assert len(lakehouse) == 1
+    assert isinstance(lakehouse[0], dict)
+    assert lakehouse[0]["displayName"] == LAKEHOUSE_NAME
+    assert lakehouse[0]["id"] == LAKEHOUSE_ID
+
 def test_get_workspace_lakehouses_by_name():
     lakehouses = get_workspace_lakehouses(workspace_name=WORKSPACE_NAME)
     assert isinstance(lakehouses, list)
     assert len(lakehouses) > 0
 
+    lakehouse = [lakehouse for lakehouse in lakehouses if lakehouse["id"] == LAKEHOUSE_ID]
+
+    assert len(lakehouse) == 1
+    assert isinstance(lakehouse[0], dict)
+    assert lakehouse[0]["displayName"] == LAKEHOUSE_NAME
+    assert lakehouse[0]["id"] == LAKEHOUSE_ID  
+
 def test_get_workspace_lakehouse_tables_by_workspace_id_and_lakehouse_id():
-    lakehouse = get_workspace_lakehouse_tables(workspace_id=WORKSPACE_ID, lakehouse_id=LAKEHOUSE_ID)
-    assert isinstance(lakehouse, list)
-    assert len(lakehouse) > 0
+    tables = get_workspace_lakehouse_tables(workspace_id=WORKSPACE_ID, lakehouse_id=LAKEHOUSE_ID)
+    assert isinstance(tables, list)
+    assert len(tables) > 0
+
 
 def test_get_workspace_lakehouse_tables_by_workspace_id_and_lakehouse_name():
-    lakehouse = get_workspace_lakehouse_tables(workspace_id=WORKSPACE_ID, lakehouse_name=LAKEHOUSE_NAME)
-    assert isinstance(lakehouse, list)
-    assert len(lakehouse) > 0
+    tables = get_workspace_lakehouse_tables(workspace_id=WORKSPACE_ID, lakehouse_name=LAKEHOUSE_NAME)
+    assert isinstance(tables, list)
+    assert len(tables) > 0
+
 
 def test_get_workspace_lakehouse_tables_by_workspace_name_and_lakehouse_id():
-    lakehouse = get_workspace_lakehouse_tables(workspace_name=WORKSPACE_NAME, lakehouse_id=LAKEHOUSE_ID)
-    assert isinstance(lakehouse, list)
-    assert len(lakehouse) > 0
+    tables = get_workspace_lakehouse_tables(workspace_name=WORKSPACE_NAME, lakehouse_id=LAKEHOUSE_ID)
+    assert isinstance(tables, list)
+    assert len(tables) > 0
+
 
 def test_get_workspace_lakehouse_tables_by_workspace_name_and_lakehouse_name():
-    lakehouse = get_workspace_lakehouse_tables(workspace_name=WORKSPACE_NAME, lakehouse_name=LAKEHOUSE_NAME)
-    assert isinstance(lakehouse, list)
-    assert len(lakehouse) > 0
+    tables = get_workspace_lakehouse_tables(workspace_name=WORKSPACE_NAME, lakehouse_name=LAKEHOUSE_NAME)
+    assert isinstance(tables, list)
+    assert len(tables) > 0
diff --git a/tests/internal/fabric_api/test_workspace.py b/tests/internal/fabric_api/test_workspace.py
@@ -15,14 +15,27 @@ def test_get_workspaces():
     assert len(workspaces) > 0
     assert isinstance(workspaces, list)
 
+    workspace = [workspace for workspace in workspaces if workspace["id"] == WORKSPACE_ID]
+
+    assert len(workspace) == 1
+    assert isinstance(workspace[0], dict)
+    assert workspace[0]["displayName"] == WORKSPACE_NAME
+    assert workspace[0]["id"] == WORKSPACE_ID
+
 def test_get_workspace_by_id():
     workspace = get_workspace(workspace_id=WORKSPACE_ID)
 
     assert isinstance(workspace, dict)
     assert workspace is not None
 
+    assert workspace["displayName"] == WORKSPACE_NAME
+    assert workspace["id"] == WORKSPACE_ID
+
 def test_get_workspace_by_name():
     workspace = get_workspace(workspace_name=WORKSPACE_NAME)
 
     assert isinstance(workspace, dict)
     assert workspace is not None
+
+    assert workspace["displayName"] == WORKSPACE_NAME
+    assert workspace["id"] == WORKSPACE_ID