Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative paths don't work for checkpoint_path #247

Open
eamonnkenny opened this issue Apr 29, 2020 · 0 comments
Open

Relative paths don't work for checkpoint_path #247

eamonnkenny opened this issue Apr 29, 2020 · 0 comments

Comments

@eamonnkenny
Copy link

On line 205 of monodepth_main.py you are splitting on dot ( split('.') ).

restore_path = args.checkpoint_path.split(".")[0]

This means that if somebody uses a relative path rather than full path (something like):

 ../monodepth/model_cityscapes
 ./monodepth/model_cityscapes

the code will fail saying that the restore_path file is invalid.

The solution is to not split on dot. Using something like adding os.dirname() or os.getcwd() with os.path.join() will not fix the problem if the split remains in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant