Some warning removals #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngelEzquerra
force-pushed
the
some_warning_removals
branch
from
4fda79e to
1c50923
Compare
Vindaar
reviewed
Mar 21, 2024
Comment on lines
+86
to
+89
| # The following cast removes the following warning: | ||
| # =destroy(storage.raw_buffer) can raise an unlisted exception: Exception | ||
| {.cast(raises: []).}: | ||
| `=destroy`(storage.raw_buffer) |
There was a problem hiding this comment.
Courtesy of @beef, who I should have mentioned on the commit message :)
Vindaar
reviewed
Mar 21, 2024
Comment on lines
44
to
72
| proc `+`*[T: SomeNumber|Complex[float32]|Complex[float64]](a, b: Tensor[T]): Tensor[T] {.noinit.} = | ||
| ## Tensor addition | ||
| #echo "+++++ SAME ++++++" | ||
| map2_inline(a, b, x + y) | ||
|
|
||
| proc `+`*[T, K: SomeNumber](a: Tensor[Complex[T]], b: Tensor[K]): Tensor[Complex[T]] {.noinit.} = | ||
| ## Tensor addition | ||
| echo "+++++ COMPLEX ++++++" | ||
| when T is K: | ||
| echo "T is K" | ||
| map2_inline(a, b, x + y) | ||
| elif T is float64: | ||
| echo "T is float64" | ||
| map2_inline(a, b, x + float64(y)) | ||
| else: | ||
| {.error: "Tensor addition not supported for tensors of types " & $T & " and " & $K} | ||
|
|
||
| proc `+`*[T, K: SomeNumber](a: Tensor[K], b: Tensor[Complex[T]]): Tensor[Complex[T]] {.noinit.} = | ||
| ## Tensor addition | ||
| echo "+++++++++++2" | ||
| when T is K: | ||
| echo "T is K" | ||
| map2_inline(a, b, x + y) | ||
| elif T is float64: | ||
| echo "T is float64" | ||
| map2_inline(a, b, float64(x) + y) | ||
| else: | ||
| {.error: "Complex tensor addition only supported for tensors of the same type."} | ||
|
|
There was a problem hiding this comment.
I guess this is part of this PR by accident?
There was a problem hiding this comment.
Definitely, sorry about that. I'll remove this spurious change and update the PR.
|
I'm pretty sure I added some of these "useless" import things (like the Given that doc generation is still partially broken, I'd merge it for now. Then do another pass soon to fix the doc generation soon. Maybe at this point we can attempt again to simplify the doc generation logic... |
AngelEzquerra
force-pushed
the
some_warning_removals
branch
from
9758437 to
be4eabb
Compare
…eprecated" warning from tensor\datatypes.nim Note that there is still another similar warning left in: \laser\primitives\matrix_multiplication\gemm_tiling.nim(321, 3)
In particular: - Warning: imported and not used: 'datatypes' - Warning: imported and not used: 'complex' Warning: imported and not used: 'math'
Removed from `examples\ex06_shakespeare_generator.nim`.
…r is deprecated` warning We cannot really fix that warning because it is due to the fact that (as for 2.0.2) nim creates a var destructor when `new X, T` is called. Since we cannot fix it we simply disable it.
This also removes a few unnecessary imports of the complex and math modules (which are automatically exported by arraymancer). The test touches a lot funtions but the changes are minimal and simple (basically changing things like `import unittest, os` into `import std / [unittest, os]` and so on).
This warning only happens with devel. The fix is to make sequninit.nim "used" when newSeqUninit is not needed.
AngelEzquerra
force-pushed
the
some_warning_removals
branch
from
be4eabb to
5f82fe2
Compare
|
Let's see if the docgen will really break. Thanks! |
|
Yeah, the docgen is now broken again: https://github.com/mratsim/Arraymancer/actions/runs/8387852728/job/22970876430 with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes many warnings and some unnecessary hints. Some of this is similar to a draft PR that @mratsim opened a few months ago, so there is some overlap with his work.
Note that one of the warnings could not really be fixed so I just disabled it. This is explained in the code and in the corresponding commit message.