mac/type: change array type from Any to Sendable #15611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all values mapped to the array are immutable or value type values, though the Any type implies any type including mutables or reference types. all mpv_node data can be represented as the former. change Any to Sendable, which implies mutable or values type values. this is also a preparation for swift 6 and strict concurrency support.
|
probably should bump the swift support with this. Sendable was initially implemented with swift 5.5, changed in 5.6 and reimplemented in 5.7. see https://github.com/swiftlang/swift-evolution/blob/main/proposals/0302-concurrent-value-and-concurrent-closures.md#revision-history and older versions: |
|
Download the artifacts for this pull request: |
|
sry, closing this for now. need to first figure out how to best drop the support for older swift versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all values mapped to the array are immutable or value type values, though the Any type implies any type including mutables or reference types. all mpv_node data can be represented as the former.
change Any to Sendable, which implies mutable or values type values.
this is also a preparation for swift 6 and strict concurrency support.