Merge pull request #7 from yuvalherziger/master

null if invalid boolean
mpscholten · Jun 29, 2016 · c725a77 · c725a77
2 parents ba083d6 + 5f2b92e
commit c725a77
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/BooleanParser.php b/src/BooleanParser.php
@@ -6,7 +6,13 @@ class BooleanParser extends AbstractValueParser
 {
     protected function parse($value)
     {
-        return strtoupper($value) === 'TRUE' || strtoupper($value) === '1';
+        if (strtoupper($value) === 'TRUE' || $value === '1') {
+            return true;
+        }
+        if (strtoupper($value) === 'FALSE' || $value === '0') {
+            return false;
+        }
+        return null;
     }
 
     /**

diff --git a/src/YesNoBooleanParser.php b/src/YesNoBooleanParser.php
@@ -6,7 +6,13 @@ class YesNoBooleanParser extends AbstractValueParser
 {
     protected function parse($value)
     {
-        return strtoupper($value) === 'YES' || strtoupper($value) === 'Y';
+        if (strtoupper($value) === 'YES' || strtoupper($value) === 'Y') {
+            return true;
+        }
+        if (strtoupper($value) === 'NO' || strtoupper($value) === 'N') {
+            return false;
+        }
+        return null;
     }
 
     /**