-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add newer electron versions #3702
base: master
Are you sure you want to change the base?
Add newer electron versions #3702
Conversation
Thanks @dudewheresmycode, do you have a successfull run of GitHub Actions to show ? |
@lissyx I'm not that familiar with the GitHub Actions workflow of this project. But, I think I was able to get a (mostly) successful run on my fork here: I was able to get a clean build for MacOS of the electron binaries. But hit some errors on Windows and Linux builds. Hoping you can advise there. Note: I had to update the URL for |
Sorry, but it looks like there are failures, can you fix them? |
@lissyx, sorry but the errors in the test failures might be a bit over my head. I'm not sure they're related directly to the electron version bump. The windows failure seems to be the main TensorFlow lib for Windows being unable to compile properly.
The linux failure seems to be at the @lissyx, have you run the current master branch through GitHub Actions recently to make sure it's all still passing without these changes? |
If windows is failing to build,
I am not working on this project anymore, so I advise to have a look at older PRs merged on https://github.com/mozilla/DeepSpeech/commits/master and see their status. It's possible there has been GitHub Actions specific regressions, I'd suspect the Windows ones for example. But I really have no time to investigate and fix those. |
Adds current stable electron versions to the TC build utils.
Related Issue: #3701