Prevent dependabot from proposing Python version upgrades beyond 3.11. #3038
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willkg
approved these changes
Oct 17, 2024
| @@ -14,6 +14,9 @@ updates: | |||
| interval: "weekly" | |||
| rebase-strategy: "disabled" | |||
| open-pull-requests-limit: 10 | |||
| ignore: | |||
| - dependency-name: python | |||
| versions: [">=3.12"] | |||
There was a problem hiding this comment.
I never know what to do in situations like this where there are multiple places in the code base related to a single thing, but they're not connected.
For example, we have this ignore bit here and it's tied to the docker base image we use. When we update the docker base image, we need to remember to update this, too. Will we? What helps us remember? Should we add a comment to docker/Dockerfile? Should we have a runbook for updating the Python version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we want to upgrade Python to a newer version at some point, I don't think it's useful for depednabot to suggest this to us every week.