Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AndyZe, mikeferguson, JafarAbdi, felixvd as maintainers #514

Merged
merged 2 commits into from
Sep 30, 2020

Conversation

davetcoleman
Copy link
Member

@davetcoleman davetcoleman commented Sep 29, 2020

As discussed in offline maintainer emails and during last public working group

image

- Move to inactive bmagyar, IanTheEngineer, 130s
- Alphabatize maintainers
- Update Core Contributors
Copy link
Contributor

@felixvd felixvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although you could have "alphabatized" the Core Contributors while you were at it :)

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you sort maintainers, you should sort core contributors and alumni as well.

@davetcoleman
Copy link
Member Author

It was late at night and I was lazy, but fixed:
image

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@v4hn
Copy link
Contributor

v4hn commented Sep 29, 2020

We discussed this somewhere else before with @tylerjw :
Sorting by first name strikes me as really awkward and last time we ended up sorting by last name.

A "leaderboard" would be a nice addition, sorting by contributions in the last year, but that idea clearly does not belong in this PR. :-)

@davetcoleman
Copy link
Member Author

I really like the leaderboard idea! I actually already have one in GSheets that scrapes the Github API, but would be awesome to expose that to the webpage.

Regarding sorting by first or last, I don't care if you want to open a new PR to re-order them by last but for now I'd like to merge the maintainer additions. Instead of manual sorting, I also think we could setup some Jekyll magic

@davetcoleman davetcoleman merged commit 56d7f86 into moveit:main Sep 30, 2020
@davetcoleman davetcoleman deleted the add_remove_maintainers branch September 30, 2020 03:52
@v4hn
Copy link
Contributor

v4hn commented Sep 30, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants