-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AndyZe, mikeferguson, JafarAbdi, felixvd as maintainers #514
Add AndyZe, mikeferguson, JafarAbdi, felixvd as maintainers #514
Conversation
- Move to inactive bmagyar, IanTheEngineer, 130s - Alphabatize maintainers - Update Core Contributors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although you could have "alphabatized" the Core Contributors while you were at it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you sort maintainers, you should sort core contributors and alumni as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
We discussed this somewhere else before with @tylerjw : A "leaderboard" would be a nice addition, sorting by contributions in the last year, but that idea clearly does not belong in this PR. :-) |
I really like the leaderboard idea! I actually already have one in GSheets that scrapes the Github API, but would be awesome to expose that to the webpage. Regarding sorting by first or last, I don't care if you want to open a new PR to re-order them by last but for now I'd like to merge the maintainer additions. Instead of manual sorting, I also think we could setup some Jekyll magic |
I really like the leaderboard idea! I actually already have one in GSheets that scrapes the Github API
Would be great to see this on the website! :-)
|
As discussed in offline maintainer emails and during last public working group